Downstream fabric 0.19.5 - #504
Merged
Merged
Conversation
Contributor
Author
|
Also on my machine the test fails without any error. |
Contributor
|
Oh here you are in case you didn't see here's what I wrote on Discord (although not sure to what function) 
|
AlexIIL
marked this pull request as ready for review
August 29, 2026 12:30
Contributor
Author
|
Dude it's done. Nice! |
AlexIIL
pushed a commit
that referenced
this pull request
Aug 29, 2026
* Fix LanguageAdapter javadoc * Fix .x version predicates for more than 3 components * Add system property to disable environment stripping * Update Mixin, class-tweaker and mapping-io, add compt entry and update tiny remapper * Small fix * Update mixin extras to 0.5.5, predicting modmus * Fix tests (probably) * Bump fabric loader version * Fix formatting. * Pre-bump version. --------- Co-authored-by: AlexIIL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't do the tests (6ddfc3b) and left for you to bump the quilt version. Also don't forget to add the new version in
impl/launch/common/QuiltMixinVersions.java:line41. Finally, I managed to pull off dc09edc which I initially said I couldn't do. Unfortunately, though, I wasn't able to implement 69d725e with my current knowledge. I tried a lot but I couldn't. Anyway, I am keeping this PR as draft to allow you to add whatever is left in the same commit unless you explicitly tell me not to. Have a nice day!