Skip to content

Do not start guivm for notifications#82

Merged
marmarek merged 1 commit into
QubesOS:mainfrom
marmarek:guivm-autostart
Aug 23, 2025
Merged

Do not start guivm for notifications#82
marmarek merged 1 commit into
QubesOS:mainfrom
marmarek:guivm-autostart

Conversation

@marmarek

Copy link
Copy Markdown
Member

Notifications proxy is started before GUI agent, so just starting a VM
will trigger the service. Theoretically starting associated GUI domain
shouldn't be an issue (to have where to show the notification), but in
practice there are a few corner cases here:

  • when setting up GUI domain (especially sys-gui-gpu) there are a bunch
    of steps involved, and starting it too early may interrupt them (as
    sys-gui-gpu takes keyboard/mouse away from dom0).
  • just starting GUI domain usually won't make notifications work yet -
    user needs to log into that GUI domain first

QubesOS/qubes-issues#889

Notifications proxy is started before GUI agent, so just starting a VM
will trigger the service. Theoretically starting associated GUI domain
shouldn't be an issue (to have where to show the notification), but in
practice there are a few corner cases here:
 - when setting up GUI domain (especially sys-gui-gpu) there are a bunch
   of steps involved, and starting it too early may interrupt them (as
   sys-gui-gpu takes keyboard/mouse away from dom0).
 - just starting GUI domain usually won't make notifications work yet -
   user needs to log into that GUI domain first

QubesOS/qubes-issues#889
@qubesos-bot

qubesos-bot commented Aug 11, 2025

Copy link
Copy Markdown

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025082204-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update

  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/qDqV_-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

6 failures
  • system_tests_extra

    • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/qDqV_-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/149225#dependencies

72 fixed

Unstable tests

Details

Performance Tests

Performance degradation:

19 performance degradations
  • fedora-42-xfce_exec-data-duplex: 77.02 🔺 ( previous job: 67.92, degradation: 113.40%)
  • fedora-42-xfce_exec-data-duplex-root: 110.39 🔺 ( previous job: 96.36, degradation: 114.56%)
  • whonix-gateway-17_exec-data-duplex: 76.46 🔺 ( previous job: 68.38, degradation: 111.81%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 228398.00 :small_red_triangle: ( previous job: 265260.00, degradation: 86.10%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 196773.00 :small_red_triangle: ( previous job: 431512.00, degradation: 45.60%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 147957.00 :small_red_triangle: ( previous job: 196254.00, degradation: 75.39%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 11851.00 :small_red_triangle: ( previous job: 23940.00, degradation: 49.50%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 2866.00 :small_red_triangle: ( previous job: 5874.00, degradation: 48.79%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 230253.00 :small_red_triangle: ( previous job: 292489.00, degradation: 78.72%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 69818.00 :small_red_triangle: ( previous job: 110817.00, degradation: 63.00%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 3829.00 :small_red_triangle: ( previous job: 6356.00, degradation: 60.24%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3485.00 :small_red_triangle: ( previous job: 3925.00, degradation: 88.79%)
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2501.00 :small_red_triangle: ( previous job: 3020.00, degradation: 82.81%)
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 65787.00 :small_red_triangle: ( previous job: 79539.00, degradation: 82.71%)
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3193.00 :small_red_triangle: ( previous job: 3765.00, degradation: 84.81%)
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1095.00 :small_red_triangle: ( previous job: 1251.00, degradation: 87.53%)
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 342896.00 :small_red_triangle: ( previous job: 383531.00, degradation: 89.41%)
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 124047.00 :small_red_triangle: ( previous job: 157382.00, degradation: 78.82%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7808.00 :small_red_triangle: ( previous job: 8804.00, degradation: 88.69%)

Remaining performance tests:

53 tests
  • debian-13-xfce_exec: 6.80 🟢 ( previous job: 8.36, improvement: 81.30%)
  • debian-13-xfce_exec-root: 26.79 🟢 ( previous job: 27.36, improvement: 97.91%)
  • debian-13-xfce_socket: 7.77 🟢 ( previous job: 8.57, improvement: 90.62%)
  • debian-13-xfce_socket-root: 8.77 🔺 ( previous job: 8.26, degradation: 106.19%)
  • debian-13-xfce_exec-data-simplex: 70.68 🟢 ( previous job: 72.43, improvement: 97.59%)
  • debian-13-xfce_exec-data-duplex: 74.69 🟢 ( previous job: 76.65, improvement: 97.44%)
  • debian-13-xfce_exec-data-duplex-root: 87.50 🟢 ( previous job: 91.79, improvement: 95.33%)
  • debian-13-xfce_socket-data-duplex: 146.70 🔺 ( previous job: 133.45, degradation: 109.93%)
  • fedora-42-xfce_exec: 9.02 🟢 ( previous job: 9.06, improvement: 99.52%)
  • fedora-42-xfce_exec-root: 58.48 🔺 ( previous job: 58.19, degradation: 100.51%)
  • fedora-42-xfce_socket: 8.09 🟢 ( previous job: 8.48, improvement: 95.40%)
  • fedora-42-xfce_socket-root: 8.14 🟢 ( previous job: 8.18, improvement: 99.47%)
  • fedora-42-xfce_exec-data-simplex: 64.66 🟢 ( previous job: 78.48, improvement: 82.38%)
  • fedora-42-xfce_socket-data-duplex: 142.97 🔺 ( previous job: 142.58, degradation: 100.27%)
  • whonix-gateway-17_exec: 7.75 🟢 ( previous job: 8.12, improvement: 95.48%)
  • whonix-gateway-17_exec-root: 39.28 🟢 ( previous job: 41.05, improvement: 95.67%)
  • whonix-gateway-17_socket: 8.79 🔺 ( previous job: 8.52, degradation: 103.08%)
  • whonix-gateway-17_socket-root: 8.36 🔺 ( previous job: 8.12, degradation: 103.04%)
  • whonix-gateway-17_exec-data-simplex: 71.82 🟢 ( previous job: 83.60, improvement: 85.91%)
  • whonix-gateway-17_exec-data-duplex-root: 94.93 🟢 ( previous job: 99.37, improvement: 95.53%)
  • whonix-gateway-17_socket-data-duplex: 165.35 🟢 ( previous job: 167.12, improvement: 98.94%)
  • whonix-workstation-17_exec: 8.07 🔺 ( previous job: 7.57, degradation: 106.54%)
  • whonix-workstation-17_exec-root: 53.56 🟢 ( previous job: 56.76, improvement: 94.36%)
  • whonix-workstation-17_socket: 7.93 🟢 ( previous job: 8.59, improvement: 92.37%)
  • whonix-workstation-17_socket-root: 8.89 🔺 ( previous job: 8.89, degradation: 100.00%)
  • whonix-workstation-17_exec-data-simplex: 69.36 🔺 ( previous job: 66.80, degradation: 103.82%)
  • whonix-workstation-17_exec-data-duplex: 74.42 🟢 ( previous job: 74.50, improvement: 99.88%)
  • whonix-workstation-17_exec-data-duplex-root: 101.16 🟢 ( previous job: 102.34, improvement: 98.85%)
  • whonix-workstation-17_socket-data-duplex: 152.62 🔺 ( previous job: 147.97, degradation: 103.14%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 490447.00 :small_red_triangle: ( previous job: 497426.00, degradation: 98.60%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3256.00 :green_circle: ( previous job: 2446.00, improvement: 133.12%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 2245.00 :green_circle: ( previous job: 29.00, improvement: 7741.38%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 417925.00 :green_circle: ( previous job: 137802.00, improvement: 303.28%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 160038.00 :green_circle: ( previous job: 121719.00, improvement: 131.48%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 104503.00 :green_circle: ( previous job: 103932.00, improvement: 100.55%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7928.00 :green_circle: ( previous job: 7695.00, improvement: 103.03%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 375833.00 :green_circle: ( previous job: 366891.00, improvement: 102.44%)
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 155702.00 :green_circle: ( previous job: 140215.00, improvement: 111.05%)
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 283016.00 :small_red_triangle: ( previous job: 299764.00, degradation: 94.41%)
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 44557.00 :small_red_triangle: ( previous job: 47575.00, degradation: 93.66%)
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 87901.00 :green_circle: ( previous job: 86001.00, improvement: 102.21%)
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8615.00 :small_red_triangle: ( previous job: 9042.00, degradation: 95.28%)
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1698.00 :green_circle: ( previous job: 1368.00, improvement: 124.12%)
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 393905.00 :green_circle: ( previous job: 387500.00, improvement: 101.65%)
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 156874.00 :green_circle: ( previous job: 136640.00, improvement: 114.81%)
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 356779.00 :green_circle: ( previous job: 325139.00, improvement: 109.73%)
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 92085.00 :green_circle: ( previous job: 87396.00, improvement: 105.37%)
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 9027.00 :green_circle: ( previous job: 8992.00, improvement: 100.39%)
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 292980.00 :small_red_triangle: ( previous job: 293225.00, degradation: 99.92%)
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 76897.00 :green_circle: ( previous job: 64217.00, improvement: 119.75%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81624.00 :small_red_triangle: ( previous job: 87141.00, degradation: 93.67%)
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4122.00 :green_circle: ( previous job: 4098.00, improvement: 100.59%)
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2192.00 :small_red_triangle: ( previous job: 2384.00, degradation: 91.95%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants