Prioritize sys-usb before other autostarted VMs#76
Conversation
|
What's the right way to apply just |
e96e0a2 to
813ae61
Compare
rustybird
changed the title
Yes, I think so. Following on the forum discussion - does it result systemd complaining about ordering loop? Or using the same drop-in as sys-usb avoids that? If it is a problem, maybe also override |
813ae61 to
d8c17a8
Compare
Honestly, I don't like putting non-package-owned files in /usr. Normally I'd say user can use a higher-numbered file, but you can't remove dependencies this way. So, maybe make it configurable via pillar instead, so user can enable/disable this ordering without needing to change the file after each package update? In fact, you may want to reuse the one for USB keyboard, as that's the primary reason for this ordering (to have keyboard working at lightdm prompt). |
| rm -f /srv/pillar/_tops/dom0/qvm.top | ||
| fi | ||
|
|
||
| qubesctl state.sls qvm.sys-usb-prioritize-autostart |
There was a problem hiding this comment.
This must to be under some condition. User may not have sys-usb at all, or may have changed them (renamed, split into multiple etc). In fact, this %post will execute also at the initial package installation time when there are no VMs at all yet. Maybe check for the ordering drop-in existence?
There was a problem hiding this comment.
I've backed out of that commit for now (and the /usr/lib one).
Maybe check for the ordering drop-in existence?
Is the USB VM always named sys-usb if it's created by Salt?
There was a problem hiding this comment.
Is the USB VM always named sys-usb if it's created by Salt?
I was asking because the state files seem to make some effort to softcode the name in salt['pillar.get']('qvm:sys-usb:name', 'sys-usb'), but I've never heard about how a user should go about configuring a different name.
Maybe check for the ordering drop-in existence?
The latest commit does that, using a hardcoded sys-usb name in the drop-in path.
I was going to write yes it prints a harmless
Tried it with |
d8c17a8 to
103d786
Compare
Hmm, users could also override via |
957d6d2 to
ec81722
Compare
systemd-user-sessions.service is waiting for sys-usb, so let's start that one first.
ec81722 to
e4ae100
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071903-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 10 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:9 performance degradations
Remaining performance tests:63 tests
|
3 participants
See commit message