Add warning about domain names/ip addresses to VM settings#454
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 69.71% 69.66% -0.05%
==========================================
Files 17 17
Lines 4029 4029
==========================================
- Hits 2809 2807 -2
- Misses 1220 1222 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marmarta
marked this pull request as draft
July 5, 2026 15:08
Member
Author
|
discussion about wording ongoing in the ticket |
make it clearer that domain names are a lie. fixes QubesOS/qubes-issues#8809
marmarta
marked this pull request as ready for review
July 13, 2026 14:27
marmarek
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make it clearer that domain names are a lie.
fixes QubesOS/qubes-issues#8809