Allow Appmenu custom positioning#50
Conversation
12851ce to
629f5b7
Compare
|
Pylint errors fixes, Most unittests updated, rpm_spec updated |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 81.88% 82.33% +0.44%
==========================================
Files 22 22
Lines 2269 2338 +69
==========================================
+ Hits 1858 1925 +67
- Misses 411 413 +2 ☔ View full report in Codecov by Sentry. |
2f3192b to
f3762c4
Compare
|
@marmarta this is ready for review The patch for Appmenu positioning, Appmenu Settings patch and unittests is done. |
marmarta
left a comment
marmarta
left a comment
There was a problem hiding this comment.
I did not know how much I needed it, wow! I installed this PR for testing and I already love it. Thank you! A small change request on the test, but otherwise, love this.
5c136e8 to
5b70e0b
Compare
Glad that you liked it. The unittest is now updated |
|
@marmarek , this may also be helpful to combat the weird KDE bugs with location of the menu? Not sure about that, it is some wayland blood magic that, but maybe? |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024110204-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable testsDetails
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@DemiMarie just stop. You have better things to do. |
5b70e0b to
89edaf3
Compare
5 participants
fixes: QubesOS/qubes-issues#9093