Fix repo setting logic in global config#319
Merged
Merged
Conversation
Member
Author
|
yes I am aware this is not a nicest fix. I'm open to corrections. I hate everything. |
Member
|
Can you describe, in words, what the intended behavior should be? Why repositories with "dom0" in name are special? |
Member
Author
|
There are two repo widgets:
Should this go into a comment? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 92.73% 92.67% -0.06%
==========================================
Files 66 66
Lines 13618 13631 +13
==========================================
+ Hits 12628 12633 +5
- Misses 990 998 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Yes, that would be helpful |
Member
Author
|
ok done |
marmarek
reviewed
Jul 5, 2026
| # the selected option) | ||
| # checkbuttons for everything else (where we just want to enable/disable | ||
| # based on state) | ||
| dom0_found = False |
Member
There was a problem hiding this comment.
This is all very confusing... If leaving this structure, at least make this variable name more descriptive. Maybe dom0_cutoff_found?
Alternatively, a more readable option would be to abandon common handling for both types, and have a helper dict with list of repositories to enable for each dom0 selection. Like:
{ "qubes-dom0-current-testing": ["qubes-dom0-current-testing", "qubes-dom0-security-testing", "qubes-dom0-current"],
"qubes-dom0-security-testing" : ["qubes-dom0-security-testing", "qubes-dom0-current"],
"qubes-dom0-current": ["qubes-dom0-current"]
}
Abandon the hope of having a clever single solution, just do dom0 updates and template repos separately. Also added a test for all the bugs. fixes QubesOS/qubes-issues#9366 fixes QubesOS/qubes-issues#9868 fixes QubesOS/qubes-issues#8802
Member
Author
|
Alright, I rewrote it for less "I'm clever" and more "this can be understood by anyone, including me in a month". Plus bonus test. |
This was referenced Jul 14, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026071518-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:16 performance degradations
Remaining performance tests:95 tests
|
This was referenced Jul 14, 2026
marmarek
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes QubesOS/qubes-issues#9366
fixes QubesOS/qubes-issues#9868
fixes QubesOS/qubes-issues#8802