Skip to content

Fix wrong event name #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Oct 10, 2025
Merged

Fix wrong event name #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions qubesappmenusext/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ async def update_appmenus(self, vm):
if not guivm.is_running():
self.log.warning("GUI VM for '%s' is not running, queueing menu update", vm.name)
# please no async code between those two calls
current_queue = guivm.features.get('menu-update-pending-for', '').split(' ')
current_queue = guivm.features.get('menu-update-pending-for', '').split()
if vm.name not in current_queue:
guivm.features['menu-update-pending-for'] = ' '.join(current_queue + [vm.name])
return
Expand All @@ -90,7 +90,7 @@ async def remove_appmenus(self, vm_name, guivm):
if not guivm.is_running():
self.log.warning("GUI VM for '%s' is not running, queueing menu removal", vm_name)
# please no async code between those two calls
current_queue = guivm.features.get('menu-remove-pending-for', '').split(' ')
current_queue = guivm.features.get('menu-remove-pending-for', '').split()
if vm_name not in current_queue:
guivm.features['menu-remove-pending-for'] = ' '.join(current_queue + [vm_name])
return
Expand Down Expand Up @@ -226,16 +226,18 @@ def on_feature_set_internal(self, vm, event, feature, value,
self.vm_tasks[vm.name].append(
asyncio.ensure_future(self.remove_appmenus(vm.name, vm.guivm)))

@qubes.ext.handler('domains-start')
@qubes.ext.handler('domain-start')
async def on_domain_start(self, vm, event, **kwargs):
"""Process queued menu updates"""
pending_update = vm.features.get('menu-update-pending-for', '').split(' ')
pending_remove = vm.features.get('menu-remove-pending-for', '').split(' ')
if pending_update or pending_remove:
vm.log.info("Processing pending menu updates")
pending_remove = vm.features.get('menu-remove-pending-for', '').split()
pending_update = vm.features.get('menu-update-pending-for', '').split()
if pending_remove:
vm.log.info("Processing pending menu removals")
for to_remove in pending_remove:
await self.remove_appmenus(to_remove, guivm=vm)
del vm.features['menu-update-pending-for']
del vm.features['menu-remove-pending-for']
if pending_update:
vm.log.info("Processing pending menu updates")
for to_update in pending_update:
if to_update not in vm.app.domains:
# removed in the meantime, and should be handled
Expand Down