Move all binaries from /usr/sbin to /usr/bin#68
Merged
Conversation
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030306-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/129058#dependencies 15 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:31 performance degradations
Remaining performance tests:41 tests
|
marmarek
force-pushed
the
sbin-to-bin
branch
2 times, most recently
from
March 1, 2025 22:52
4b09725 to
b2ca33f
Compare
In practice only qubesdb-daemon remained in /usr/sbin. Since Fedora 42 merged those two, it ends up in /usr/bin anyway, and since its harmless on other distros, move it everywhere. This simplifies for example systemd unit handling (which otherwise would sometimes need /usr/bin and sometimes /usr/sbin path). But keep /usr/sbin/qubesdb-daemon compatibility symlink in RPM distros that don't merge sbin with bin yet. This especially applies to F41-based dom0, where qubesd referrs to /usr/sbin/qubesdb-daemon. QubesOS/qubes-issues#9807
This was referenced Mar 3, 2025
Merged
DemiMarie
reviewed
Mar 3, 2025
DemiMarie
left a comment
DemiMarie
left a comment
Contributor
There was a problem hiding this comment.
Other than the confusing commented-out entries in .gitlab-ci.yml, looks good to me.
Comment on lines
+12
to
+13
| # - file: /r4.3/gitlab-host-qwt.yml | ||
| # project: QubesOS/qubes-continuous-integration |
Contributor
There was a problem hiding this comment.
Why is this present but commented out? 😕
Member
Author
There was a problem hiding this comment.
To be uncommented when QWT tests in CI will be back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In practice only qubesdb-daemon remained in /usr/sbin.
Since Fedora 42 merged those two, it ends up in /usr/bin anyway, and
since its harmless on other distros, move it everywhere. This simplifies
for example systemd unit handling (which otherwise would sometimes need
/usr/bin and sometimes /usr/sbin path).
QubesOS/qubes-issues#9807