Documentation#148
Merged
Merged
Conversation
DemiMarie
force-pushed
the
docs
branch
2 times, most recently
from
April 24, 2024 22:44
4d4cf8c to
1d6e04e
Compare
Member
|
This has conflicts now... |
DemiMarie
force-pushed
the
docs
branch
2 times, most recently
from
May 9, 2024 16:43
d16b9e2 to
634f3a7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 54 54
Lines 9618 9618
=======================================
Hits 7496 7496
Misses 2122 2122 ☔ View full report in Codecov by Sentry. |
marmarek
requested changes
May 18, 2024
DemiMarie
force-pushed
the
docs
branch
2 times, most recently
from
May 19, 2024 22:34
bfaf861 to
18af3d8
Compare
Member
|
I see most comments to the rst file are addressed, but still few remained. And there are few typos in the header to fix. |
I plan on keeping this in this repository, rather than in the docs repo, for maintenance reasons.
marmarek
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I plan on keeping this in this repository, rather than in the docs repo, for maintenance reasons.
Also fix a memory leak and refactor the code to make it easier to document.
Based on #140.