pdf-converter: add renderer dispatch#43
Merged
Merged
Conversation
Jayant-kernel
marked this pull request as ready for review
May 17, 2026 07:06
Jayant-kernel
force-pushed
the
gsoc-converter-dispatch
branch
from
May 17, 2026 07:08
df217b7 to
cc5317f
Compare
Contributor
Author
|
@marmarek |
Jayant-kernel
force-pushed
the
gsoc-converter-dispatch
branch
from
May 19, 2026 05:41
cc5317f to
47e0aba
Compare
marmarek
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small structure-only follow-up to #42.
It adds a simple renderer dispatch table on the server side and creates the current PDF renderer through that path. BaseFile now receives the renderer it should use instead of creating PdfRenderer directly.
PDF is still the only registered renderer in this PR. There is no new file type support yet, and no intended change to qvm-convert-pdf, qubes.PdfConvert, or the qrexec protocol.
Tests:
python -c "import sys, unittest; sys.argv=['unittest']; suite=unittest.defaultTestLoader.discover('qubespdfconverter/tests', pattern='test*.py'); result=unittest.TextTestRunner(verbosity=2).run(suite); sys.exit(not result.wasSuccessful())"git diff --cached --checkbefore commit