Fix pickable issue on Role._hash#45
Merged
Merged
Conversation
Member
Author
|
PipelineRetry |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 1 1
Lines 215 215
=======================================
Hits 180 180
Misses 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
fepitre
force-pushed
the
fix-threadpool
branch
2 times, most recently
from
May 28, 2026 11:21
a8ec42b to
cabe529
Compare
Member
What is the purpose of this tag in the commit message? |
Member
Author
To revert it on newer Ansible version. As I understood it happens because of old ansible version available? |
Member
|
I'm not sure, it might be just because of newer python version. |
Member
|
Yes, the pickle problem is in this plugin, not ansible itself. Multiprocessing changed in newer python and now every object used there needs to be picklable - it wasn't required before. Threads are a bit more tricky in some cases, but at least they work, so I guess that would be the target solution. |
fepitre
force-pushed
the
fix-threadpool
branch
2 times, most recently
from
June 2, 2026 07:55
ef8d192 to
038c9f4
Compare
Also retarget the mgmtvm qrexec policy at the default management dispvm template instead of a hardcoded fedora-42-xfce, otherwise admin.vm.List from mgmtvm omits the new fedora-43-xfce template and clone tests against qubes.default_template.name fail with "Cannot clone the 'fedora-43-xfce' because it doesn't exist".
play.get_roles() returns one entry per role usage, so the same role listed twice with different when: makes shutil.copytree fail on the second copy with FileExistsError.
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026060401-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests24 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 16 fixed
Unstable testsDetails
Performance TestsPerformance degradation:23 performance degradations
Remaining performance tests:88 tests
|
This was referenced Jun 4, 2026
marmarek
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.