Skip to content

Use failure name as upload failure can be empty #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Oct 4, 2025
Merged

Use failure name as upload failure can be empty #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/github_reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def format_results(results, jobs, reference_jobs=None, instability_analysis=None
fails = results[k]
add_to_output = ""
for fail in fails:
if fail in upload_failures:
if fail.name == "system_tests":
continue
if fail.regression and not fail.unstable:
add_to_output += ' * ' + str(fail) + '\n'
Expand All @@ -109,7 +109,7 @@ def format_results(results, jobs, reference_jobs=None, instability_analysis=None
continue
add_to_output = ""
for fail in results[k]:
if fail.fixed or fail in upload_failures:
if fail.fixed or fail.name == "system_tests":
continue
if fail.unstable:
add_to_output += ' * [unstable] ' + str(fail) + '\n'
Expand Down