Add --force-separate-as-imports option to keep non-aliased imports grouped together - #2598
Open
n0gu-furiosa wants to merge 2 commits into
Open
Add --force-separate-as-imports option to keep non-aliased imports grouped together#2598n0gu-furiosa wants to merge 2 commits into
--force-separate-as-imports option to keep non-aliased imports grouped together#2598n0gu-furiosa wants to merge 2 commits into
Conversation
Author
|
Hi @DanielNoord, could you take a look and share your thoughts on this PR when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
--force-separate-as-imports, which separates the non-aliased import group from the aliased import group.This is a proposed minimal change for #2455. The design for this issue is not decided yet, so this PR is a demo and does not include documentation or test updates. Once the design is accepted, I will work on those too.
File1.py:
Without the option (which behaves the same as main, no breaking changes)
$ isort file1.py -d --fss from module import (AAAAAAAAAAAAAAAAAAAAAAAAAA, BBBBBBBBBBBBBBBBBBBBBBBBBB, CCCCCCCCCCCCCCCCCCCCCCCCCC) from module import (EEEEEEEEEEEEEEEEEEEEEEEEEE, FFFFFFFFFFFFFFFFFFFFFFFFFF, GGGGGGGGGGGGGGGGGGGGGGGGGG) from module import DDDDDDDDDDDDDDDDDDDDDDDDDD as dWith the option:
$ isort file1.py -d --fss --fsai from module import (AAAAAAAAAAAAAAAAAAAAAAAAAA, BBBBBBBBBBBBBBBBBBBBBBBBBB, CCCCCCCCCCCCCCCCCCCCCCCCCC, EEEEEEEEEEEEEEEEEEEEEEEEEE, FFFFFFFFFFFFFFFFFFFFFFFFFF, GGGGGGGGGGGGGGGGGGGGGGGGGG) from module import DDDDDDDDDDDDDDDDDDDDDDDDDD as d