-
Notifications
You must be signed in to change notification settings - Fork 47
Fixes styling for civi sepa dashboard #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
knottheory
wants to merge
8
commits into
Project60:master
Choose a base branch
from
knottheory:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+194
−170
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8c12559
Added stylsheet for dashboard backgrounds. Updated the action buttons…
knottheory 136bea9
Added link to new stylesheet #216
knottheory 3a8c018
Added class to the legend table, so that the background colour would …
knottheory 65ea84c
Swapped href attribute in buttons for p and q
knottheory 846e140
Added crm extension key to the tamplate and removed every occurance o…
knottheory bc2385f
Added type hinting and doc section to the core resource list function
knottheory c22eb21
Updated the selector using BEM conventions and making its name more d…
knottheory 70994fb
Merge branch 'master' into master
knottheory File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| .sepa_dashboard tr.submit_missed td { | ||
| background-color: var(--crm-danger-light-color, #EE0000AA); | ||
| } | ||
|
|
||
| .sepa_dashboard tr.submit_urgently td { | ||
| background-color: var(--crm-warning-light-color, #AC6700AA); | ||
| } | ||
|
|
||
| .sepa_dashboard tr.submit_soon td { | ||
| background-color: var(--crm-info-light-color, #0165FFAA); | ||
| } | ||
|
|
||
| .sepa_dashboard tr.submit_later td { | ||
| background-color: var(--crm-success-light-color, #008300AA); | ||
| } | ||
|
|
||
| .sepa_dashboard tr.submit_closed td { | ||
| background-color: var(--crm-layer2-bg-color, #00830033); | ||
| } | ||
|
|
||
| .sepa_dashboard .sepa_dashboard__button_group { | ||
| display: flex; | ||
| justify-content: end; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the table cell have to be
display: flex;? - this actually causes the buttons to grow in height and shouldn't be necessary.The buttons are
inline-blocksotext-align: right;should be enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adresses the table cell containing the buttons. Setting the display property to flex aligns the buttons horizontally instead of vertical. The overall screen space the buttons take up is reduced.
Nonetheless the selector could be more descriptive.