Skip to content

Add derivative for PAIN format "pain.008.001.02 without BIC and CdtrSchmId:Nm" with conditional address for Switzerland - #654

Open
Detsieber wants to merge 2 commits into
Project60:masterfrom
Detsieber:master
Open

Add derivative for PAIN format "pain.008.001.02 without BIC and CdtrSchmId:Nm" with conditional address for Switzerland#654
Detsieber wants to merge 2 commits into
Project60:masterfrom
Detsieber:master

Conversation

@Detsieber

Copy link
Copy Markdown
Member

This is a fix for #639.

This is tested in production and works well.

@Detsieber

Copy link
Copy Markdown
Member Author

Would be nice to include into 1.7

@bjendres

Copy link
Copy Markdown
Member

Hi @Detsieber, thanks for the PR. But, as stated in #639 (comment), please adjust the PR so it creates a new file format with the desired properties. This way we won't jeopardise the submissions of people using the file format you're changing...

@bjendres bjendres added this to the 1.7 milestone Oct 19, 2022
@jensschuppe jensschuppe changed the title Fix for #639 Add derivative for PAIN format "pain.008.001.02 without BIC and CdtrSchmId:Nm" with conditional address for Switzerland Oct 20, 2022
@jensschuppe jensschuppe added the status:needs work There is code, but it needs additional work before it should be reviewed label Oct 20, 2022
@jensschuppe

Copy link
Copy Markdown
Contributor

Copying from #639 what needs to be done here:

  • Add a directory for the new format in templates/Sepa/Formats/ with an appropriate name
  • Add the files Format.php, transaction-details.tpl, transaction-header.tpl and transaction-footer.tpl inside that directory (possibly copying from the existing format you wanted to adjust - make sure to adjust the class name in Format.php)
  • Add the format to the option group resource file
  • Add an upgrade task that synchronises that option group with the corresponding resource file

@bjendres

Copy link
Copy Markdown
Member

remark: the commits 21ddc47 and 9340a39 mentioned above do not belong to this issue.

@bjendres bjendres modified the milestones: 1.7, 1.8 Nov 16, 2022
@bjendres bjendres modified the milestones: 1.8.x, 1.9.x Feb 22, 2023
@bjendres bjendres modified the milestones: 1.9.x, 1.10, Scheduled Features Jun 22, 2023
@bjendres

Copy link
Copy Markdown
Member

FYI, we solved this problem with two creditors: one for switzerland with an format that has the address in the file, and another one for all other countries. I think the SEPA-Tools extension allows you to define the creditor based on a regex of the IBAN...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature status:needs work There is code, but it needs additional work before it should be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants