Repository navigation
Add keyless web search to the Open WebUI preset - #282
Open
georgeatparallel wants to merge 2 commits into
Open
georgeatparallel wants to merge 2 commits into
georgeatparallel wants to merge 2 commits into
Conversation
khosravipasha
requested changes
Nov 2, 2026
khosravipasha
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Reviewing on behalf of the maintainers
Thanks for contributing this! Keyless search could be useful for the demo, and preserving existing tool selections and access grants is a good improvement. A few points before merging:
- Please isolate PATH in the MCP tests and add a subprocess timeout. The “bridge missing” test inherited my actual PATH, found the installed Brave bridge, launched it, and hung at
wait. I stopped the test and bridge; all 15 tests passed when rerun with an isolated PATH. The tests should guarantee that behavior themselves. - Is the legacy Search MCP endpoint intentional for this integration? Your docs recommend the newer unified MCP for new installs. Keeping the smaller search-only endpoint may make sense, but please confirm it will remain supported for this demo.
- For new model records, this automatically attaches remote search. I would lean toward making it available but opt-in; if we keep it attached by default, please make that clear at startup, including that search queries go to Parallel and that users can disable it with
BONSAI_WEB_SEARCH=none. It also adds tool-schema overhead to the prompt.
Please also confirm a live search round-trip with our pinned Open WebUI version, including how anonymous rate-limit errors are presented. My validation covered the isolated tests, not a live Open WebUI search.
No need to make this elaborate; a small test fix and clarification of the endpoint/default behavior should keep it manageable. Thanks again!
Review follow-ups: - Tests: the preset tests now run with a PATH that holds only their fixtures plus symlinks to the commands the preset calls, so a Brave bridge installed on the machine running the tests can no longer be discovered, started, and waited on. The preset runs in its own process group with a 30s timeout, so a stuck child fails the test instead of hanging it. A new test plants a bridge on the host PATH and asserts it is neither found nor started. - Search is available but not attached: no MCP server is added to new model records, web search included, so nothing is sent to a search provider until a chat enables it from the tool menu. Re-seeding still preserves saved tool selections and access grants. The launcher banner now names the provider, says where queries go, and points at BONSAI_WEB_SEARCH=none. - Documented why the demo stays on the standalone, search-only Search MCP (free, keyless, two tools) even though Parallel's docs mark it legacy and point new installs at the unified mcp.parallel.ai server. Co-authored-by: George Pickett <georgeatparallel@users.noreply.github.com>
cursor
Bot
force-pushed
the
parallel-search-f746aa2e-7957-46c3-8e34-c207ef4cb4c5
branch
from
November 2, 2026 21:11
1eeac4b to
afcf561
Compare
Author
|
Thanks for the careful review, @khosravipasha. I pushed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh Open WebUI installations can search the web with Parallel Search MCP, with no account, API key, or local bridge needed. Anonymous searches use Fast mode.
The launcher uses Parallel when no Brave key is configured. Existing
BRAVE_API_KEYor.brave_keyconfigurations keep Brave selected, including its news and summarizer tools. SetBONSAI_WEB_SEARCH=parallel|brave|noneto select or disable the connection. Existing model tool selections and access grants survive re-seeding; existing models can select the available server from the chat tool menu.For general web search, Artificial Analysis's Search API benchmark reports DeepSearchQA F1 of 0.802 for Parallel Fast and 0.623 for Brave Search. Source.
I work at Parallel.