fix: restore standalone GPU trainer launch - #3362
Open
LeonEricsson wants to merge 3 commits into
Open
Conversation
LeonEricsson
marked this pull request as ready for review
August 23, 2026 12:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
background
The README’s environment setup check:
currently fails during distributed initialization due to missing environment variables in
os.environ(also noted here. Standalone launches used to work becausetrainer/envs.pycalledset_defaultsat import time, writingRANKetc into os.environ. #2193 deleted that and inlinedos.environ.get("RANK", "0") intoWorld`.proposal
Rather than reinstate env mutation
setup_torch_distributednow passes an in-process HashStore with rank=0, world_size=1 when no launcher is present.An alternative would be to make the trainer entrypoint a launcher that re-execs under torchrun the way
sftandrlalready do.