-
Notifications
You must be signed in to change notification settings - Fork 16
feat: built-in bash skill (bash -c, shell parity with a native tool) #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+93
−0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62f6639
feat: built-in bash skill (await bash(...)), executing via bash -c
samsja 75d58b8
feat: bash skill enforces the git-history guard + harness timeout def…
samsja 702d9b1
chore: drop bash skill output clipping — return raw output
samsja 03f601b
fixup: complete output-clip removal
samsja bab8cf6
fix: actually register the bash skill in _BUILTIN_SKILLS
samsja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| """Built-in ``bash`` skill — run a shell command from the REPL. | ||
|
|
||
| Enabled via ``RLM_SKILLS``; pre-imported into the IPython kernel so the agent calls | ||
| ``await bash(command="...")`` (or ``await bash("...")``). One command per call, a fresh | ||
| ``bash -c`` subshell, with the same git-history guard as shell tool paths. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import asyncio | ||
| import os | ||
| import subprocess | ||
|
|
||
| from rlm.tools.git_block import find_blocked_command, refusal | ||
|
|
||
|
|
||
| def _default_timeout() -> int: | ||
| raw = os.environ.get("RLM_EXEC_TIMEOUT", "") | ||
| return int(raw) if raw.isdigit() and int(raw) > 0 else 300 | ||
|
|
||
|
|
||
| def _run_bash(command: str, timeout: int) -> str: | ||
| """Execute via ``bash -c`` (never /bin/sh) and return combined output.""" | ||
| blocked = find_blocked_command(command) | ||
| if blocked: | ||
| return refusal(blocked) | ||
| try: | ||
| proc = subprocess.run( | ||
| ["bash", "-c", command], | ||
| capture_output=True, | ||
| text=True, | ||
| timeout=timeout, | ||
| ) | ||
| except subprocess.TimeoutExpired: | ||
| return f"Error: command timed out after {timeout}s" | ||
| out = proc.stdout + (("\n" + proc.stderr) if proc.stderr else "") | ||
| if proc.returncode != 0: | ||
| out += f"\n[exit code {proc.returncode}]" | ||
| return out.strip() or "(no output)" | ||
|
|
||
|
|
||
| async def run(command: str, timeout: int | None = None) -> str: | ||
| """Run a shell command and return its combined output. | ||
|
|
||
| Args: | ||
| command: The shell command to run (executed with ``bash -c``). | ||
| timeout: Seconds before the command is killed (default: the harness | ||
| exec timeout via ``RLM_EXEC_TIMEOUT``, else 300). | ||
|
|
||
| Returns: | ||
| stdout and stderr of the command (with the exit code when nonzero). | ||
| """ | ||
| return await asyncio.to_thread(_run_bash, command, timeout or _default_timeout()) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.