Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/polymarket/_internal/actions/gamma.py
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,6 @@ def list_markets_spec(
liquidity_num_max: float | None = None,
liquidity_num_min: float | None = None,
locale: str | None = None,
market_maker_addresses: str | Sequence[str] | None = None,
order: str | None = None,
position_ids: str | Sequence[str] | None = None,
question_ids: str | Sequence[str] | None = None,
Expand Down Expand Up @@ -549,7 +548,6 @@ def list_markets_spec(
_add_optional(params, "liquidity_num_max", liquidity_num_max)
_add_optional(params, "liquidity_num_min", liquidity_num_min)
_add_optional(params, "locale", locale)
_add_optional_seq(params, "market_maker_address", market_maker_addresses)
_add_optional(params, "order", order)
_add_optional_seq(params, "position_ids", position_ids)
_add_optional_seq(params, "question_ids", question_ids)
Expand Down
2 changes: 0 additions & 2 deletions src/polymarket/clients/async_public.py
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,6 @@ def list_markets(
liquidity_num_max: float | None = None,
liquidity_num_min: float | None = None,
locale: str | None = None,
market_maker_addresses: str | Sequence[str] | None = None,
order: str | None = None,
position_ids: str | Sequence[str] | None = None,
question_ids: str | Sequence[str] | None = None,
Expand Down Expand Up @@ -1045,7 +1044,6 @@ def list_markets(
liquidity_num_max=liquidity_num_max,
liquidity_num_min=liquidity_num_min,
locale=locale,
market_maker_addresses=market_maker_addresses,
order=order,
position_ids=position_ids,
question_ids=question_ids,
Expand Down
2 changes: 0 additions & 2 deletions src/polymarket/clients/async_secure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1716,7 +1716,6 @@ def list_markets(
liquidity_num_max: float | None = None,
liquidity_num_min: float | None = None,
locale: str | None = None,
market_maker_addresses: str | Sequence[str] | None = None,
order: str | None = None,
position_ids: str | Sequence[str] | None = None,
question_ids: str | Sequence[str] | None = None,
Expand Down Expand Up @@ -1757,7 +1756,6 @@ def list_markets(
liquidity_num_max=liquidity_num_max,
liquidity_num_min=liquidity_num_min,
locale=locale,
market_maker_addresses=market_maker_addresses,
order=order,
position_ids=position_ids,
question_ids=question_ids,
Expand Down
2 changes: 0 additions & 2 deletions src/polymarket/clients/public.py
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,6 @@ def list_markets(
liquidity_num_max: float | None = None,
liquidity_num_min: float | None = None,
locale: str | None = None,
market_maker_addresses: str | Sequence[str] | None = None,
order: str | None = None,
position_ids: str | Sequence[str] | None = None,
question_ids: str | Sequence[str] | None = None,
Expand Down Expand Up @@ -835,7 +834,6 @@ def list_markets(
liquidity_num_max=liquidity_num_max,
liquidity_num_min=liquidity_num_min,
locale=locale,
market_maker_addresses=market_maker_addresses,
order=order,
position_ids=position_ids,
question_ids=question_ids,
Expand Down
2 changes: 0 additions & 2 deletions src/polymarket/clients/secure.py
Original file line number Diff line number Diff line change
Expand Up @@ -1244,7 +1244,6 @@ def list_markets(
liquidity_num_max: float | None = None,
liquidity_num_min: float | None = None,
locale: str | None = None,
market_maker_addresses: str | Sequence[str] | None = None,
order: str | None = None,
position_ids: str | Sequence[str] | None = None,
question_ids: str | Sequence[str] | None = None,
Expand Down Expand Up @@ -1285,7 +1284,6 @@ def list_markets(
liquidity_num_max=liquidity_num_max,
liquidity_num_min=liquidity_num_min,
locale=locale,
market_maker_addresses=market_maker_addresses,
order=order,
position_ids=position_ids,
question_ids=question_ids,
Expand Down
8 changes: 0 additions & 8 deletions src/polymarket/models/gamma/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,6 @@ class TagReference(BaseModel):
updated_at: datetime | None = Field(default=None, validation_alias="updatedAt")
force_hide: bool | None = Field(default=None, validation_alias="forceHide")
is_carousel: bool | None = Field(default=None, validation_alias="isCarousel")
requires_translation: bool | None = Field(
default=None,
validation_alias="requiresTranslation",
)
active_events_count: int | None = Field(default=None, validation_alias="activeEventsCount")

@field_validator("published_at", "created_at", "updated_at", mode="before")
Expand Down Expand Up @@ -158,10 +154,6 @@ class SeriesReference(BaseModel):
cg_asset_name: str | None = Field(default=None, validation_alias="cgAssetName")
score: int | None = None
comment_count: int | None = Field(default=None, validation_alias="commentCount")
requires_translation: bool | None = Field(
default=None,
validation_alias="requiresTranslation",
)

@field_validator("id", mode="before")
@classmethod
Expand Down
8 changes: 0 additions & 8 deletions src/polymarket/models/gamma/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ class EventState(BaseModel):
ended: bool | None = None
automatically_active: bool | None = Field(default=None, validation_alias="automaticallyActive")
comments_enabled: bool | None = Field(default=None, validation_alias="commentsEnabled")
requires_translation: bool | None = Field(
default=None,
validation_alias="requiresTranslation",
)


class EventSchedule(BaseModel):
Expand Down Expand Up @@ -94,7 +90,6 @@ def _parse_event_date(cls, value: object) -> date | None:

class EventMetrics(BaseModel):
liquidity: Decimal | None = None
liquidity_amm: Decimal | None = Field(default=None, validation_alias="liquidityAmm")
liquidity_clob: Decimal | None = Field(default=None, validation_alias="liquidityClob")
volume: Decimal | None = None
volume_24hr: Decimal | None = Field(default=None, validation_alias="volume24hr")
Expand All @@ -108,7 +103,6 @@ class EventMetrics(BaseModel):

@field_validator(
"liquidity",
"liquidity_amm",
"liquidity_clob",
"volume",
"volume_24hr",
Expand Down Expand Up @@ -358,7 +352,6 @@ def _normalize_event(cls, value: object) -> object:
"ended": data.get("ended"),
"automatically_active": data.get("automaticallyActive"),
"comments_enabled": data.get("commentsEnabled"),
"requires_translation": data.get("requiresTranslation"),
},
"schedule": {
"start_date": data.get("startDate"),
Expand All @@ -372,7 +365,6 @@ def _normalize_event(cls, value: object) -> object:
},
"metrics": {
"liquidity": data.get("liquidity"),
"liquidity_amm": data.get("liquidityAmm"),
"liquidity_clob": data.get("liquidityClob"),
"volume": data.get("volume"),
"volume_24hr": data.get("volume24hr"),
Expand Down
5 changes: 0 additions & 5 deletions src/polymarket/models/gamma/market.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,6 @@ class MarketMetrics(BaseModel):
default=None,
validation_alias="volume1yr",
)
volume_amm: Decimal | None = Field(
default=None,
validation_alias="volumeAmm",
)
volume_clob: Decimal | None = Field(
default=None,
validation_alias="volumeClob",
Expand Down Expand Up @@ -494,7 +490,6 @@ def _normalize_market(cls, value: object) -> object:
"volume_1wk": data.get("volume1wk"),
"volume_1mo": data.get("volume1mo"),
"volume_1yr": data.get("volume1yr"),
"volume_amm": data.get("volumeAmm"),
"volume_clob": data.get("volumeClob"),
"liquidity": data.get("liquidity"),
"liquidity_num": data.get("liquidityNum"),
Expand Down
21 changes: 18 additions & 3 deletions tests/unit/test_gamma_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ def _minimal_market_payload(**overrides: object) -> dict[str, object]:
"outcomePrices": ["0.6", "0.4"],
"clobTokenIds": ["TOKEN-YES", "TOKEN-NO"],
"positionIds": ["POSITION-YES", "POSITION-NO"],
"marketMakerAddress": "0xMM",
}
payload.update(overrides)
return payload
Expand All @@ -53,6 +52,24 @@ def test_market_parses_minimal_payload() -> None:
assert market.position_ids == ("POSITION-YES", "POSITION-NO")


def test_market_ignores_legacy_fields_still_present_in_responses() -> None:
# The API stopped returning these fields, but historical AMM markets and
# not-yet-migrated responses may still carry them.
market = Market.parse_response(
_minimal_market_payload(
marketMakerAddress="0xMM",
ammType="fpmm",
fpmmLive=True,
volumeAmm="123.45",
liquidityAmm="67.89",
pagerDutyNotificationEnabled=True,
requiresTranslation=True,
)
)

assert market.id == "MARKET-1"


def test_market_normalizes_groups_from_flat_payload() -> None:
payload = _minimal_market_payload(
slug="my-market",
Expand Down Expand Up @@ -365,14 +382,12 @@ def test_event_skips_markets_with_non_binary_outcomes() -> None:
"outcomes": ["Yes", "No"],
"outcomePrices": ["0.5", "0.5"],
"clobTokenIds": ["A", "B"],
"marketMakerAddress": "0xMM",
},
{
"id": "M2",
"outcomes": ["Only"],
"outcomePrices": ["1"],
"clobTokenIds": ["X"],
"marketMakerAddress": "0xMM",
},
],
)
Expand Down
3 changes: 0 additions & 3 deletions tests/unit/test_gamma_paginated_specs.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ def _minimal_market_payload(**overrides: object) -> dict[str, object]:
"outcomePrices": ["0.6", "0.4"],
"clobTokenIds": ["TOKEN-YES", "TOKEN-NO"],
"positionIds": ["POSITION-YES", "POSITION-NO"],
"marketMakerAddress": "0xMM",
}
payload.update(overrides)
return payload
Expand Down Expand Up @@ -72,14 +71,12 @@ def test_list_markets_spec_default_has_no_params() -> None:
def test_list_markets_spec_collects_array_params() -> None:
spec = gamma_actions.list_markets_spec(
clob_token_ids=["A", "B"],
market_maker_addresses=["0xMM"],
ids=[1, 2],
position_ids=["P1", "P2"],
)

assert spec.base_params == {
"clob_token_ids": ("A", "B"),
"market_maker_address": ("0xMM",),
"id": (1, 2),
"position_ids": ("P1", "P2"),
}
Expand Down
Loading