Skip to content

Guard gzip pool behind canImport(zlib) for non-Darwin host builds #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
poly-jeff wants to merge 1 commit into from
Closed

Guard gzip pool behind canImport(zlib) for non-Darwin host builds #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Libraries/Connect/Public/Implementation/Compression/GzipCompressionPool.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@
// limitations under the License.

import Foundation
#if canImport(zlib)
import zlib
#endif

/// Compression pool that handles gzip compression/decompression.
public struct GzipCompressionPool: Sendable {
Expand All @@ -22,6 +24,10 @@ public struct GzipCompressionPool: Sendable {
public enum GzipError: Error {
case failedToInitialize
case failedToFinish
/// Thrown on platforms where `zlib` is unavailable (e.g. the non-Darwin Swift
/// toolchain used for Android/Skip host builds), so gzip callers fail loudly
/// rather than the whole module failing to compile.
case unsupportedPlatform
}
}

Expand All @@ -30,6 +36,7 @@ extension GzipCompressionPool: CompressionPool {
return "gzip"
}

#if canImport(zlib)
public func compress(data: Data) throws -> Data {
if data.isEmpty || data.isGzipped() {
return data
Expand Down Expand Up @@ -135,6 +142,15 @@ extension GzipCompressionPool: CompressionPool {
output.count = Int(stream.total_out)
return output
}
#else
public func compress(data: Data) throws -> Data {
throw GzipError.unsupportedPlatform
}

public func decompress(data: Data) throws -> Data {
throw GzipError.unsupportedPlatform
}
#endif
}

private extension Data {
Expand Down
Loading