Skip to content

fix: catch fetch errors in ensureBuilderFeeRateCached for browser compatibility #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osr21 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: catch fetch errors in ensureBuilderFeeRateCached for browser compatibility #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c68f68
fix: catch fetch errors in ensureBuilderFeeRateCached for browser compat
osr21 Jul 24, 2026
9cebfe7
fix: do not overwrite real fee rates with zero-fallback on parallel-c…
osr21 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1726,11 +1726,23 @@ export class ClobClient {
if (!builderCode || builderCode === bytes32Zero) return;
if (builderCode in this.builderFeeRates) return;

const result = await this.get(`${this.host}${GET_BUILDER_FEES}${builderCode}`);
this.builderFeeRates[builderCode] = {
maker: result.builder_maker_fee_rate_bps / BUILDER_FEES_BPS,
taker: result.builder_taker_fee_rate_bps / BUILDER_FEES_BPS,
};
try {
const result = await this.get(`${this.host}${GET_BUILDER_FEES}${builderCode}`);
this.builderFeeRates[builderCode] = {
maker: result.builder_maker_fee_rate_bps / BUILDER_FEES_BPS,
taker: result.builder_taker_fee_rate_bps / BUILDER_FEES_BPS,
};
} catch {
// GET /fees/builder-fees/<code> returns 404 with no CORS headers in
// browser environments, causing createOrder/createMarketOrder to fail
// before any order is built. Default to zero so order creation is not
// blocked in browser contexts. Only write the fallback when the slot is
// still empty — guards against a parallel-call race where a successful
// fetch already populated real rates before this catch branch fires.
if (!(builderCode in this.builderFeeRates)) {
this.builderFeeRates[builderCode] = { maker: 0, taker: 0 };
}
}
}

private async _resolveTickSize(tokenID: string, tickSize?: TickSize): Promise<TickSize> {
Expand Down