feat: support beacon deposit wallets - #34
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a74e346. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
Linear: PRO-318
Note
Medium Risk
Wrong address prediction could misroute funds or batch signing; mitigated by deployed-UUPS fallback, beacon-absent fallback, and regression tests.
Overview
Adds beacon-based deposit wallet support so predicted addresses match factories that deploy ERC-1967 beacon clones, not only legacy UUPS CREATE2 math.
RelayClient.deriveDepositWalletAddress()now uses an on-chain viem public client: it reads the factory beacon (or treats revert/missing beacon as none), returns the UUPS address when there is no beacon or that wallet is already deployed, otherwise returns the beacon CREATE2 address. A trailingRelayClientOptionslets callers override the viemchain(must matchchainId). The standalonederiveDepositWallet()export stays as a deprecated UUPS-only wrapper; beacon derivation is internal and not re-exported from the package root.Docs steer integrators to
client.deriveDepositWalletAddress(). Tests cover fixed UUPS/beacon hashes and the three runtime branches;@ethersproject/providersandwalletare added for pnpm-isolated builds.Reviewed by Cursor Bugbot for commit ce0b684. Bugbot is set up for automated code reviews on this repo. Configure here.