feat(finnhub): add Get EBITDA Estimate action (#21071)#21130
feat(finnhub): add Get EBITDA Estimate action (#21071)#21130Aldebaran638 wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified. |
|
Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAdds a Finnhub action to fetch company EBITDA estimates: introduces FREQUENCIES, adds a freq prop and getEbitdaEstimate method to the Finnhub app, implements the Get EBITDA Estimate action (symbol + freq), and bumps the component version to 0.3.0. ChangesFinnhub EBITDA Estimate Action
🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs`:
- Line 6: Update the action description in get-ebitda-estimate.mjs to follow the
agent-friendly structure: start with a one-line purpose (what the action does),
add a brief "When to use" sentence describing the use case, include a
"Parameters" note listing expected inputs/format (e.g., symbol, fiscalPeriod,
etc.) and any gotchas (rate limits, missing data), then finish with the existing
"[See the documentation](https://finnhub.io/docs/api/company-ebitda-estimates)"
link; modify the description field in the action metadata so it contains these
sections in plain text prior to the docs link to improve agent guidance.
In `@components/finnhub/finnhub.app.mjs`:
- Around line 49-56: Update the freq prop description to explicitly enumerate
allowed values and show an inline example so agents format input correctly:
change the description for freq (the property defined as freq with options:
constants.FREQUENCIES) to list the concrete allowed values (e.g., "allowed:
annual, quarterly, monthly") and include a short example like "e.g., 'annual'".
Ensure the text remains a single sentence describing allowed values and the
example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 23240395-690a-4217-ab00-fb7f32d64250
📒 Files selected for processing (4)
components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjscomponents/finnhub/common/constants.mjscomponents/finnhub/finnhub.app.mjscomponents/finnhub/package.json
…t review - Expand EBITDA action description with detailed context and premium requirement note - Clarify freq prop with explicit allowed values (annual/quarterly) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ashwins01
left a comment
There was a problem hiding this comment.
Hi @Aldebaran638, thank you for your contribution! Looks good to me. Waiting on further steps before I approve and move this to QA, since this requires Finnhub premium.
cc: @s0s0physm
Summary
Add new action to retrieve EBITDA estimates for a company via Finnhub API.
Closes #21071
Changes
Get EBITDA Estimate(components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs)freqprop definition to Finnhub app for annual/quarterly frequency selectionFREQUENCIESconstant incommon/constants.mjsfor dropdown optionsgetEbitdaEstimatemethod to Finnhub appTesting
/stock/ebitda-estimateverified in Finnhub documentationChecklist
Please check the following items before your PR can be reviewed:
Versioning
0.0.1for new ones)package.json's version updatedNew app
If this is a new app, please submit an app integration request - the PR will only be reviewed after the app is integrated.
CodeRabbit review
After the PR is opened, and if new changes are pushed, CodeRabbit will automatically review it. Do not 'mark as resolved' CodeRabbit's comments, but reply to them instead, whether you agree (and update the PR accordingly) or disagree.
Summary by CodeRabbit