Skip to content

feat(finnhub): add Get EBITDA Estimate action (#21071)#21130

Open
Aldebaran638 wants to merge 5 commits into
PipedreamHQ:masterfrom
Aldebaran638:feat/finnhub-ebitda-estimate
Open

feat(finnhub): add Get EBITDA Estimate action (#21071)#21130
Aldebaran638 wants to merge 5 commits into
PipedreamHQ:masterfrom
Aldebaran638:feat/finnhub-ebitda-estimate

Conversation

@Aldebaran638

@Aldebaran638 Aldebaran638 commented Jun 11, 2026

Copy link
Copy Markdown

Summary

Add new action to retrieve EBITDA estimates for a company via Finnhub API.

Closes #21071

Changes

  • Add new action Get EBITDA Estimate (components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs)
  • Add freq prop definition to Finnhub app for annual/quarterly frequency selection
  • Add FREQUENCIES constant in common/constants.mjs for dropdown options
  • Add getEbitdaEstimate method to Finnhub app
  • Bump package version from 0.2.0 to 0.3.0

Testing

  • ✅ Code passes ESLint checks (pre-commit hook)
  • ✅ API endpoint /stock/ebitda-estimate verified in Finnhub documentation
  • ⚠️ Unable to test with free API key as EBITDA Estimates requires Premium subscription

Checklist

Please check the following items before your PR can be reviewed:

Versioning

  • All components updated in this PR had their version updated (0.0.1 for new ones)
  • The app updated in this PR had its package.json's version updated

New app

If this is a new app, please submit an app integration request - the PR will only be reviewed after the app is integrated.

  • The app updated in this PR is already integrated

CodeRabbit review

After the PR is opened, and if new changes are pushed, CodeRabbit will automatically review it. Do not 'mark as resolved' CodeRabbit's comments, but reply to them instead, whether you agree (and update the PR accordingly) or disagree.

  • I have addressed or acknowledged all of CodeRabbit's review comments

Summary by CodeRabbit

  • New Features
    • Added EBITDA estimate retrieval for companies via the Finnhub integration, with configurable frequency options.
    • Frequency choices include annual (default) and quarterly; results are returned with a summary of the retrieved data.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
pipedream-docs-redirect-do-not-edit Ignored Ignored Jun 26, 2026 12:19pm

Request Review

@pipedream-component-development

Copy link
Copy Markdown
Collaborator

Thank you so much for submitting this! We've added it to our backlog to review, and our team has been notified.

@pipedream-component-development

Copy link
Copy Markdown
Collaborator

Thanks for submitting this PR! When we review PRs, we follow the Pipedream component guidelines. If you're not familiar, here's a quick checklist:

@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: d3051d24-0121-4289-8007-4d08d3941102

📥 Commits

Reviewing files that changed from the base of the PR and between e074fd2 and 76ab4c0.

📒 Files selected for processing (2)
  • components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs
  • components/finnhub/finnhub.app.mjs

📝 Walkthrough

Walkthrough

Adds a Finnhub action to fetch company EBITDA estimates: introduces FREQUENCIES, adds a freq prop and getEbitdaEstimate method to the Finnhub app, implements the Get EBITDA Estimate action (symbol + freq), and bumps the component version to 0.3.0.

Changes

Finnhub EBITDA Estimate Action

Layer / File(s) Summary
Frequency constants
components/finnhub/common/constants.mjs
FREQUENCIES array is added with "annual" and "quarterly" values for API frequency selection.
App capability: frequency prop and EBITDA fetch method
components/finnhub/finnhub.app.mjs
freq optional property is added to the app props (wired to FREQUENCIES, defaulting to "annual"), and getEbitdaEstimate async method is added to call _makeRequest with the /stock/ebitda-estimate endpoint.
Get EBITDA Estimate action and version bump
components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs, components/finnhub/package.json
A new action accepts symbol and freq props, calls this.app.getEbitdaEstimate, exports a success summary, and returns the response; package version updated from 0.2.0 to 0.3.0.

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title 'feat(finnhub): add Get EBITDA Estimate action (#21071)' clearly and concisely describes the main change: adding a new EBITDA Estimate action to the Finnhub component.
Description check ✅ Passed The pull request description follows the provided template structure, includes a summary, detailed changes, testing notes, and completes all required checklist items for versioning and CodeRabbit review.
Linked Issues check ✅ Passed The PR successfully implements the core requirement from issue #21071: adding a pre-built Pipedream action for Finnhub's /stock/ebitda-estimate endpoint with proper parameter handling (symbol and frequency).
Out of Scope Changes check ✅ Passed All changes are directly scoped to implementing the EBITDA Estimate action: new action module, app method, frequency constant, and version bump. No unrelated modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs`:
- Line 6: Update the action description in get-ebitda-estimate.mjs to follow the
agent-friendly structure: start with a one-line purpose (what the action does),
add a brief "When to use" sentence describing the use case, include a
"Parameters" note listing expected inputs/format (e.g., symbol, fiscalPeriod,
etc.) and any gotchas (rate limits, missing data), then finish with the existing
"[See the documentation](https://finnhub.io/docs/api/company-ebitda-estimates)"
link; modify the description field in the action metadata so it contains these
sections in plain text prior to the docs link to improve agent guidance.

In `@components/finnhub/finnhub.app.mjs`:
- Around line 49-56: Update the freq prop description to explicitly enumerate
allowed values and show an inline example so agents format input correctly:
change the description for freq (the property defined as freq with options:
constants.FREQUENCIES) to list the concrete allowed values (e.g., "allowed:
annual, quarterly, monthly") and include a short example like "e.g., 'annual'".
Ensure the text remains a single sentence describing allowed values and the
example.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 23240395-690a-4217-ab00-fb7f32d64250

📥 Commits

Reviewing files that changed from the base of the PR and between 1784939 and e074fd2.

📒 Files selected for processing (4)
  • components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs
  • components/finnhub/common/constants.mjs
  • components/finnhub/finnhub.app.mjs
  • components/finnhub/package.json

Comment thread components/finnhub/actions/get-ebitda-estimate/get-ebitda-estimate.mjs Outdated
Comment thread components/finnhub/finnhub.app.mjs
Aldebaran638 and others added 2 commits June 11, 2026 09:10
…t review

- Expand EBITDA action description with detailed context and premium requirement note
- Clarify freq prop with explicit allowed values (annual/quarterly)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@michelle0927 michelle0927 added the prioritized Prioritized issue label Jun 12, 2026

@ashwins01 ashwins01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Aldebaran638, thank you for your contribution! Looks good to me. Waiting on further steps before I approve and move this to QA, since this requires Finnhub premium.

cc: @s0s0physm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prioritized Prioritized issue User submitted Submitted by a user

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NEED A NEW TOOL FOR FINNHUB VIA PIPEDREAM[ACTION]

6 participants