Fix code generation with wrong language and wrong path - #299
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Invalid parameters can cause citation URL resolution to throw and prevent warning pages from rendering.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR adds handling for invalid exposure views and code-generation languages, with warnings and citation suppression.
Changes:
- Adds exposure detail route aliases.
- Validates view and language parameters.
- Adds tests for invalid paths and recovery.
| File | Changes |
|---|---|
src/router/routeAliases.ts |
Adds exposure detail route suffixes. |
src/router/index.ts |
Applies the new route aliases. |
src/components/organisms/ExposureDetail.vue |
Implements validation, warnings, and citation hiding. |
src/components/organisms/ExposureDetail.test.ts |
Tests invalid-route behavior and recovery. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
agarny
requested changes
Sep 28, 2026
agarny
left a comment
agarny
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just a minor request for change.
agarny
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #293.
Test Scenarios
MATLABwithCPP, https://akhuoa.github.io/pmrapp-frontend/exposures/210f6601f6461be8443592ff071d2592/baylor_hollingworth_chandler_2002_a.cellml/cellml_codegen/CPP, now shows a warning message for unavailable language. And it also hides the citation for this view.cellml_codegenwithcellml_codegen_x, https://akhuoa.github.io/pmrapp-frontend/exposures/210f6601f6461be8443592ff071d2592/baylor_hollingworth_chandler_2002_a.cellml/cellml_codegen_x/C, now shows a warning for unavailable view. This also hides the citation so that the users won't use the wrong pages in the citation.