enforce if brackets with checkstyle - #2582
Open
samfreund wants to merge 2 commits into
Open
Conversation
Member
|
I don't like stopping this as one liner early returns are more readable IMO |
Contributor
|
I agree that conditional return/break/continue statements are better on a single line. |
Signed-off-by: samfreund <samf.236@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
We enforce brackets for if statements now using checkStyle.
Why?
if statements without brackets can easily lead to mistakes and confusion.
Testing
AI Disclosure
Describe AI involvement here if applicable
Ngl, I didn't change all the brackets by hand
Merge Checklist
Additional Checks (if applicable)
// MIGRATION: <dataYear>where<dataYear>is the last season the pre-migration data was used in./photon-client/src/types