Remove OpenCV version check - #2570
Open
Gold856 wants to merge 1 commit into
Open
Conversation
Gold856
force-pushed
the
remove-opencv-version-check
branch
from
August 1, 2026 20:04
7e72675 to
8ec83f3
Compare
samfreund
force-pushed
the
remove-opencv-version-check
branch
from
August 2, 2026 21:43
8ec83f3 to
bcc7b4e
Compare
samfreund
previously approved these changes
Aug 5, 2026
samfreund
force-pushed
the
remove-opencv-version-check
branch
from
August 5, 2026 00:52
bcc7b4e to
bcb6526
Compare
Contributor
Implies that there isn't any process or guarantees upstream about stability (only from a nominal conops perspective), and that there is still value in this check during beta periods |
Contributor
Author
|
Due to the timing of OpenCV releases, we are almost guaranteed to not hit that scenario. OpenCV releases every 6 months; right now, it's one release in winter (around December) and one for the summer (around June or July). December is way too late for us to integrate in time for kickoff; so historically, it's the summer release that's been deployed. It's more dependent on OpenCV's schedule than anything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed?
The OpenCV version check historically used to detect incorrect OpenCV libraries has been removed.
Why?
This code and the issue it mitigated is impossible to hit by construction (at least in non-betas due to the OpenCV version being stable, however, if the OpenCV version changes during beta for some reason, you can still hit this), due to there being only one, year versioned Maven OpenCV artifact. There are no longer separate Maven artifacts per year (the year is no longer part of the group ID). This means given multiple dependencies that declare a dependency on OpenCV with differing versions, Gradle will always upgrade OpenCV to the latest version, which should typically be from GradleRIO.
Testing
OpenCV 2027-4.13.0-1 manually specified in build.gradle, upgraded to 2027-4.13.0-4 (from GradleRIO).
AI Disclosure
Merge Checklist
Additional Checks (if applicable)
./photon-client/src/types