Skip to content

Remove OpenCV version check - #2570

Open
Gold856 wants to merge 1 commit into
PhotonVision:mainfrom
Gold856:remove-opencv-version-check
Open

Remove OpenCV version check#2570
Gold856 wants to merge 1 commit into
PhotonVision:mainfrom
Gold856:remove-opencv-version-check

Conversation

@Gold856

@Gold856 Gold856 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Description

What changed?

The OpenCV version check historically used to detect incorrect OpenCV libraries has been removed.

Why?

This code and the issue it mitigated is impossible to hit by construction (at least in non-betas due to the OpenCV version being stable, however, if the OpenCV version changes during beta for some reason, you can still hit this), due to there being only one, year versioned Maven OpenCV artifact. There are no longer separate Maven artifacts per year (the year is no longer part of the group ID). This means given multiple dependencies that declare a dependency on OpenCV with differing versions, Gradle will always upgrade OpenCV to the latest version, which should typically be from GradleRIO.

Testing

  • I have tested this change locally
  • Test evidence (screenshots, videos, or test results):
image

OpenCV 2027-4.13.0-1 manually specified in build.gradle, upgraded to 2027-4.13.0-4 (from GradleRIO).


AI Disclosure

  • This PR was authored entirely by me
  • This PR includes AI-generated code (e.g., from GitHub Copilot, ChatGPT)
    • If yes, I have reviewed all AI-generated code for correctness
    • If yes, please describe which parts were AI-assisted:

Merge Checklist

Additional Checks (if applicable)

  • User-facing changes? User documentation is updated
  • Breaking changes? Migration guide is included in description
  • Bug fix? Regression test is added
  • New dependency? License compatibility is verified and steps have been taken to follow it
  • Serde changes? All messages are regenerated with no unexpected hash changes
  • Configuration changes? Changes are backwards compatible with previous season's last release
  • Pipeline/data exchange changes? Frontend types are updated in ./photon-client/src/types

@Gold856
Gold856 requested a review from a team as a code owner August 1, 2026 19:42
@github-actions github-actions Bot added the photonlib Things related to the PhotonVision library label Aug 1, 2026
@Gold856
Gold856 force-pushed the remove-opencv-version-check branch from 7e72675 to 8ec83f3 Compare August 1, 2026 20:04
@samfreund
samfreund force-pushed the remove-opencv-version-check branch from 8ec83f3 to bcc7b4e Compare August 2, 2026 21:43
samfreund
samfreund previously approved these changes Aug 5, 2026
@samfreund
samfreund force-pushed the remove-opencv-version-check branch from bcc7b4e to bcb6526 Compare August 5, 2026 00:52
@mcm001

mcm001 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

at least in non-betas due to the OpenCV version being stable, however, if the OpenCV version changes during beta for some reason, you can still hit this

Implies that there isn't any process or guarantees upstream about stability (only from a nominal conops perspective), and that there is still value in this check during beta periods

@samfreund
samfreund dismissed their stale review August 5, 2026 01:05

dismissing to avoid an accidental merge

@Gold856

Gold856 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Due to the timing of OpenCV releases, we are almost guaranteed to not hit that scenario. OpenCV releases every 6 months; right now, it's one release in winter (around December) and one for the summer (around June or July). December is way too late for us to integrate in time for kickoff; so historically, it's the summer release that's been deployed. It's more dependent on OpenCV's schedule than anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photonlib Things related to the PhotonVision library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants