Refactor Frontend - #2502
Conversation
|
We should probably have a fallback for CSS |
|
Stream padding seems largely improved with 1ebedd6
|
| <div class="pt-0"> | ||
| <div v-if="useCameraSettingsStore().isConnected" class="d-flex flex-column"> | ||
| <div v-if="!isCalibrating" class="pt-4 pb-3 pl-0 text-base font-semibold opacity-100"> | ||
| Configure New Calibration |
There was a problem hiding this comment.
All of the padding comes from the input elements and is standardized across the app. I personally think dropping the padding by multiple of our spacing constant looks worse.
This alternative gives acceptable fallback results: |
|
I don't like how you can't tell whether an element is a button or not. There should be some sort of indicator of whether something is clickable, which is currently missing. |
Could you give an example of something that isn't clearly clickable? Buttons in the app have relatively consistent styling but I'm not sure if there's a specific spot I'm missing |
The big one for me was with raw/processed stream mode. If you've only got one on, you can't turn it off , but the button doesn't change to indicate that. Similar things with other buttons. |
samfreund
left a comment
There was a problem hiding this comment.
I'm not a fan of having to import every individual icon, is there anything we can do to get around that?
f91e92a to
8af1436
Compare
I don’t really like polluting the global namespace with a dynamic icon resolver. I’d lean towards either a dedicated namespace for the resolver, or just keeping the imports. Something that collects the imports on the same line wouldn’t be terrible either. |
|
That might actually be a JSON and/or backend logic problem. While reworking code for #2511, I think some of the deletion logic I replaced lines up with that behavior. |
|
I wasn't able to reproduce on main :( |
…vision into drop-vuetify
c:\Users\matth\Documents\GitHub\photonvision\.venv\Scripts\Activate.ps1) :wq
|
For the rows (apriltags in settings, etc.) might be good to have slightly different alternating colors to make it more readable. |
|
If you rapidly switch back and forth between the AprilTag and Input Tabs, you'll note the text for the controls are offset by different amounts. This is because toggles and sliders have a different content size, but the same amount of padding, and is something I compensated for in #1972. |

















Description
This PR completely removes Vuetify from the photon-client codebase in favor of a custom component set built with Tailwind CSS and Reka UI.
Summary of changes
Meta
Merge checklist: