chore(repo): remove stray binaries, generated outputs, and dead files#6732
Merged
Merged
Conversation
- Committed binaries (~41 MB): clusterAg, isoA, m, m5 (leaked via #4548/#5394), tests/modules/main, packages/perry-styling/examples/dist/showcase, android-build .../jniLibs/arm64-v8a/libperry_app.so (build artifact, regenerated by 'perry run --target android') - Generated outputs committed by accident: wasm_ui_demo.html (root + examples, output of 'perry examples/wasm_ui_demo.ts --target wasm'), res/ (i18n-emit strings.xml output) - Dead code: src/core/wit/perry-container.wit (zero references), crates/perry-runtime/src/.value.parked/ (parked copy of the old value.rs split from #1246) - Executed plan docs / logs: NM_DEVIRT_PLAN.md (plan landed as #5256; the two source comments citing it now cite the PR), W6_ISSUE_DRAFT.md, PERF_RUN_LOG.md - .git-blame-ignore-revs: placeholder that never gained a single SHA - Superseded/orphan scripts: run_tests.sh (replaced by run_parity_tests.sh), run_llvm_sweep.sh, scripts/{run_cache_tests.sh,run_tty_pty_smoke.sh, node_builtin_manifest_radar.py,bisect_1114.sh, gc_mutable_root_contract_gate.sh,gc_ffi_root_sources_gate.py} — none invoked by CI, other scripts, or docs - Closed-issue repro demos: examples/issue_{552,582,583}_demo.ts - .gitignore: ignore the removed generated paths so they cannot come back Every deletion was reference-checked against .github/workflows, scripts/, docs/, README and crate sources. addr-class ratchet passes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (38)
💤 Files with no reviewable changes (27)
📝 WalkthroughWalkthroughThis change removes obsolete runtime modules, development scripts, issue demos, planning and performance notes, and container WIT interfaces. It also updates generated-reference comments and adds ignore patterns for generated artifacts. ChangesRepository cleanup
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reference-checked repo cleanup — every deletion below was verified against
.github/workflows,scripts/,docs/, README and crate sources before removal. No behavior changes; the only source edits are two doc comments that cited a deleted plan file.Committed binaries (~41 MB at HEAD)
clusterAg,isoA,m,m5— Mach-O executables accidentally committed at the repo root via fix(runtime): bound-method value dispatches via vtable (snapshot), fixing this.m = this.m.bind(this) #4548 / fix(hir,runtime): Annex B B.3.3 hoisting precedence + legacy method aliases (#5346) #5394tests/modules/main— compiled output oftests/modules/main.ts(sources kept)packages/perry-styling/examples/dist/showcase— binary in an examplesdist/android-build/app/src/main/jniLibs/arm64-v8a/libperry_app.so(11 MB) — build artifact;perry run --target androidcopies a freshly compiled.sohere at build time (crates/perry/src/commands/run/android.rs)Generated outputs committed by accident
wasm_ui_demo.html(root andexamples/) — output ofperry examples/wasm_ui_demo.ts --target wasm; the.tsdemo staysres/— i18n-emitstrings.xmloutput; the real Android resources live underandroid-build/app/src/main/resDead code
src/core/wit/perry-container.wit— zero references anywhere (no wit-bindgen, no build.rs, no CI)crates/perry-runtime/src/.value.parked/— parked copy of the pre-Drop all files to <2k LOC + tighten size gate from 5k to 2k #1246value.rssplit (8 files incl. a.tmp), never compiled or referencedExecuted plans / stale working docs
NM_DEVIRT_PLAN.md— the plan landed as perf(size): devirtualize native-module dispatch tables (−20% hello-world __text) #5256; the two source comments citing it (perry-codegen/src/nm_install.rs,perry-runtime/src/object/native_module_registry.rs) now cite the PR insteadW6_ISSUE_DRAFT.md,PERF_RUN_LOG.md— one-off draft/log from June.git-blame-ignore-revs— placeholder ("SHA will be filled in after the commit lands") that never gained a single SHASuperseded / orphan scripts (nothing invokes them: not CI, not other scripts, not docs)
run_tests.sh— fully superseded byrun_parity_tests.sh(sametest-files/*.tscorpus, but no Node oracle, no skip-list, fixed/tmpoutput dir)run_llvm_sweep.sh,scripts/run_cache_tests.sh,scripts/run_tty_pty_smoke.sh,scripts/node_builtin_manifest_radar.py,scripts/bisect_1114.sh(bisect helper for long-closed v0.5.1009 regression: setInterval+async MySQL query loop pegs CPU and wedges Fastify HTTP #1114),scripts/gc_mutable_root_contract_gate.sh+scripts/gc_ffi_root_sources_gate.py(the latter only called by the former)Closed-issue repro demos:
examples/issue_{552,582,583}_demo.ts(only referenced from CHANGELOG history).gitignorenow covers the removed generated paths (jniLibs/, the wasm demo HTML,/res/, the stray binary names) so they can't be re-committed.Deliberately not touched:
bucket/perry.json(live Scoop bucket per README — though it's pinned at 0.5.386 and may deserve release automation),TYPE_LOWERING*.md(active workstream doc),docs/*-plan.md(cited from source comments and translated in the book), rootCNAME(needs a check of the repo's Pages settings),docker-compose.yml/Dockerfile.dev(local dev convenience).Note: this removes the blobs from HEAD; clone size only shrinks with a history rewrite, which is out of scope here.
Summary by CodeRabbit
Chores
Documentation