Retire our Template::Tiny fork; use CPAN's#1731
Conversation
We ported the changes from our fork to the official Template::Tiny distribution, eliminating the need for our fork.
| Dancer2 maintained a fork of L<Template::Tiny> for some time that added | ||
| several features missing in the original module. These have since been | ||
| implemented, and as such, a minimum L<Template::Tiny> version of 1.16 is | ||
| required. |
There was a problem hiding this comment.
I don't think this paragraph is needed. (but then, it doesn't hurt anything, so if you want to keep it, no issue from here for that).
| Dancer2 maintained a fork of L<Template::Tiny> for some time that added | |
| several features missing in the original module. These have since been | |
| implemented, and as such, a minimum L<Template::Tiny> version of 1.16 is | |
| required. |
There was a problem hiding this comment.
Yeah, I'm not convinced it's particularly important for our documentation, it's a bit of history; if someone wants to find out more about it, the mention in the changelog that we're dropping the forked one and version control history should be enough to convey what changed and why. For current/new users, that information about older versions probably isn't that useful. as it's not like anything needs to change in their app to accommodate the change.
yanick
left a comment
yanick
left a comment
There was a problem hiding this comment.
Stick a fork in it, it's done! ;-)
bigpresh
left a comment
bigpresh
left a comment
There was a problem hiding this comment.
Nice to no longer have to carry the forked version!
I agree that the doco on the fact we used to isn't all that valuable, but I don't feel strongly either way about it.
| Dancer2 maintained a fork of L<Template::Tiny> for some time that added | ||
| several features missing in the original module. These have since been | ||
| implemented, and as such, a minimum L<Template::Tiny> version of 1.16 is | ||
| required. |
There was a problem hiding this comment.
Yeah, I'm not convinced it's particularly important for our documentation, it's a bit of history; if someone wants to find out more about it, the mention in the changelog that we're dropping the forked one and version control history should be enough to convey what changed and why. For current/new users, that information about older versions probably isn't that useful. as it's not like anything needs to change in their app to accommodate the change.
|
Removed that paragraph and merged. Thanks everyone! |
[ BUG FIXES ]
* GH #1701: Split cookie values on & only (Yanick Champoux)
[ ENHANCEMENTS ]
* GH #530: Make data censoring configurable (Yanick Champoux, David
Precious)
* GH #850: Scaffold tutorial app; allow multiple apps to be scaffolded
in core Dancer2 (Jason A. Crome)
* GH #1512: Log hook entries as they are executed (Yanick Champoux)
* GH #1615: Remove Dancer2::Template::Simple from Dancer2 core (Jason
A. Crome)
* PR #1637: New, extendable configuration system (Mikko Koivunalho)
* GH #1723: Enable use of a different Template Toolkit base class
(Andy Beverley)
* PR #1727: Don't create CPAN package files when generating new apps
(Jason A. Crome)
* PR #1731: Retire Template::Tiny fork, use CPAN's (Jason A. Crome,
Karen Etheridge, Damien Krotkine, Yanick Champoux)
* PR #1736: Allow config system to bootstrap itself (Yanick Champoux)
* GH #1737: Add on_hook_exception for errors during hook processing
(Andy Beverley)
* PR #1739: Add source to on_hook_exception (Andy Beverley)
* PR #1742: Refactor CLI for future expansion (Jason A. Crome)
[ DOCUMENTATION ]
* GH #1342: Document skipping private methods in pod coverage tests
(Jason A. Crome)
* PR #1721: New Dancer2 docs, reorganization of all documentation;
from TPRF grant (Jason A. Crome)
* PR #1741: Cover items missed in earlier documentation branch (Jason
A. Crome)
[ DEPRECATED ]
* None
[ MISC ]
* None
3 participants
We ported the changes from our fork to the official Template::Tiny distribution, eliminating the need for our fork. This PR makes explicit use of Template::Tiny 1.16 that contains the changes our fork once had, and removes all tests and forked code from our repo. The template adapter now looks for the "official" version.
Thanks to @ether, @dams and @yanick for helping to make this happen!