Scenarios and Prediction Updates #4043
Open
ananyak534 wants to merge 3 commits into
Open
Conversation
mdietze
reviewed
Jul 6, 2026
mdietze
left a comment
mdietze
left a comment
Member
There was a problem hiding this comment.
It would be good to have a readme for the overall folder that others could read to understand how to use the different scripts and how they relate to one another
| @@ -0,0 +1,310 @@ | |||
| setwd("/projectnb/dietzelab/ananyak") | |||
Member
There was a problem hiding this comment.
Before the first line of code, would be good to have some lines of documentation explaining what each script is for and the key variables that need to be set
| #normal stats are skewed when dates cluster around New Year - ex) 365 and 5 are actually close but | ||
| #numerically far apart | ||
|
|
||
| fix_wrap_doy = function(x, low_cutoff = 45, high_cutoff = 320) { |
Member
There was a problem hiding this comment.
I'd recommend roxygen style documentation for functions
|
|
||
| ##--------load lookup table--------- | ||
|
|
||
| lookup = fread("/projectnb/dietzelab/ccmmf/management/LandIQ_cropCode_lookup_table.csv") |
Member
There was a problem hiding this comment.
In general, try to put local variables that a user might need to redefine at the top
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scripts "scenarios.R" and "predict_and_store.R" now include updates that use the CARB scenarios sheet and produce county-level outputs.