Refactor the baseline Validation Pipeline to align with GSoC Architecture#4017
Merged
dlebauer merged 35 commits intoJul 2, 2026
Merged
Conversation
…rics/plot_time_series, update tests
Member
Please convert this to a dplyr or base R approach. data.table is a good package that lots of people use happily, but it is not widely used in PEcAn and its syntax is confusing to folks who don't know it already. |
divine7022
requested changes
Jun 11, 2026
divine7022
left a comment
divine7022
left a comment
Member
There was a problem hiding this comment.
overall it's in good shape, I dropped inline for thing I'd want a look at before merge
14 tasks
- Refactor run_benchmark to use 'obvs' naming convention and point plots - Update bm_validate to explicitly check for missing time/value columns - Replace stop() and warning() with PEcAn.logger equivalents - Abstract METRIC_REGISTRY into an extensible package environment - Add NSE metric and MEF alias - Update README to reflect correct data.frame inputs - Manually export load_and_map_data and add man page - Add test coverage for missing columns, R2 metric, and tolerance drops - Add info log for time alignment tolerance dropping
…r with YAML intake
11 tasks
divine7022
approved these changes
Jun 30, 2026
divine7022
left a comment
divine7022
left a comment
Member
There was a problem hiding this comment.
LGTM! thanks
heads up, never hand edit the NAMESPACE and man pages, they are supposed to be auto generated
Merged
via the queue into
PecanProject:develop
with commit Jul 2, 2026
67dded7
19 of 25 checks passed
github-project-automation
Bot
moved this from Review
to Done
in GSOC Benchmarking and Validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue tracks the follow-up changes required for the dataframe-first validation framework introduced in PR #3892 aligning it with the architecture outlined in my GSoC 2026 workplan
Planned Changes
run_benchmark()entry point into a flexible 4-stage pipeline:Validate -> Align -> Compute -> Plot.Context
PR #3892 established the baseline dataframe-first concept. The changes tracked in this issue will evolve it into the generalized, high-performance toolkit planned for Phase 2 of my GSoC project.