Repository navigation
Conversation
Contributor
📝 WalkthroughWalkthroughTwo independent edits: README.md updates rename the Mobile Development Swift entry and add a blank line before the State Management header; a new rule file ChangesDocumentation list updates
New rule: ai-agent-skills-framework
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 169: The README entry uses the broken label "SwiftGuidelines" and typo'd
description "Swiftdevelopment" while linking to swiftui-guidelines; update the
entry so the link text and description accurately reflect the resource (e.g.,
change "SwiftGuidelines" to "SwiftUI Guidelines" and "Swiftdevelopment
guidelines." to "SwiftUI development guidelines."), and ensure the link still
points to the existing swiftui-guidelines file/URL so the name, description, and
target are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| - [NativeScript](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/nativescript-cursorrules-prompt-file.mdc) - Cross-platform mobile app development. | ||
| - [React Native Expo](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/react-native-expo-cursorrules-prompt-file.mdc) - Expo-based mobile app development. | ||
| - [SwiftUI Guidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - SwiftUI development guidelines. | ||
| - [SwiftGuidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - Swiftdevelopment guidelines. |
Contributor
There was a problem hiding this comment.
Fix the README label/description typo.
SwiftGuidelines and Swiftdevelopment read like accidental text corruption, and the link still targets swiftui-guidelines. Keep the entry name and description aligned with the actual resource.
♻️ Proposed fix
- [SwiftGuidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - Swiftdevelopment guidelines.
+ [SwiftUI Guidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - Swift development guidelines.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - [SwiftGuidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - Swiftdevelopment guidelines. | |
| - [SwiftUI Guidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - Swift development guidelines. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 169, The README entry uses the broken label
"SwiftGuidelines" and typo'd description "Swiftdevelopment" while linking to
swiftui-guidelines; update the entry so the link text and description accurately
reflect the resource (e.g., change "SwiftGuidelines" to "SwiftUI Guidelines" and
"Swiftdevelopment guidelines." to "SwiftUI development guidelines."), and ensure
the link still points to the existing swiftui-guidelines file/URL so the name,
description, and target are consistent.
Add the contract-driven AI Agent Skills Framework to the Build Tools and Development section, maintaining strict alphabetical order.
Contributor
There was a problem hiding this comment.
♻️ Duplicate comments (1)
README.md (1)
169-169:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winRestore the SwiftUI label/description.
This still reads like a text corruption (
SwiftGuidelines/Swiftdevelopment) and no longer matches the linked resource name.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` at line 169, The README list item uses a corrupted label/text ("SwiftGuidelines" and "Swiftdevelopment guidelines") that doesn't match the linked resource; update the markdown list entry so the link text and description match the linked file name and intent (for example change `[SwiftGuidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc) - Swiftdevelopment guidelines.` to something like `SwiftUI Guidelines - SwiftUI development guidelines.`), ensuring the visible link text and the short description correctly reference "SwiftUI Guidelines" and the linked resource.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@README.md`:
- Line 169: The README list item uses a corrupted label/text ("SwiftGuidelines"
and "Swiftdevelopment guidelines") that doesn't match the linked resource;
update the markdown list entry so the link text and description match the linked
file name and intent (for example change
`[SwiftGuidelines](https://github.com/PatrickJS/awesome-cursorrules/blob/main/rules/swiftui-guidelines-cursorrules-prompt-file.mdc)
- Swiftdevelopment guidelines.` to something like `SwiftUI Guidelines - SwiftUI
development guidelines.`), ensuring the visible link text and the short
description correctly reference "SwiftUI Guidelines" and the linked resource.
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
rules/ai-agent-skills-framework.mdc (1)
13-20:⚠️ Potential issue | 🟠 Major | ⚡ Quick winClose the bash fence here.
The fenced code block opened for
python scripts/pipeline_validator.pyis never terminated, so the self-healing requirement and the link below are swallowed into the code block instead of being part of the rule text.Suggested fix
```bash python scripts/pipeline_validator.py + ``` 3. Self-Healing: Run diagnostic healing up to 3 times upon runtime errors before requesting human help.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rules/ai-agent-skills-framework.mdc` around lines 13 - 20, The markdown fence for the inline bash example in rules/ai-agent-skills-framework.mdc is not closed, so fix the block that starts with the line containing "python scripts/pipeline_validator.py" by adding a closing triple-backtick (```) immediately after that command (or converting the opening line to a proper fenced block with "```bash" and then closing it); ensure the subsequent "3. Self-Healing..." bullet and the link are plain text outside the fenced code block so they render correctly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@rules/ai-agent-skills-framework.mdc`:
- Around line 13-20: The markdown fence for the inline bash example in
rules/ai-agent-skills-framework.mdc is not closed, so fix the block that starts
with the line containing "python scripts/pipeline_validator.py" by adding a
closing triple-backtick (```) immediately after that command (or converting the
opening line to a proper fenced block with "```bash" and then closing it);
ensure the subsequent "3. Self-Healing..." bullet and the link are plain text
outside the fenced code block so they render correctly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: da821ac1-ff34-4606-a174-b8228a98e5f5
📒 Files selected for processing (1)
rules/ai-agent-skills-framework.mdc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added AI Agent Skills Framework to the rules ecosystem.
Unlike standard static styling rules, this framework introduces:
.pipeline_state.json) to prevent agent task evasion.pipeline_validator.py) to physically block inline colors and styling leaks.generate_mdc.py) and a Runtime self-healing loop.Highly aligned with the mission of standardizing agentic workflows!
Summary by CodeRabbit