fix: improve KeyPattern.NAMESPACE_PATTERN regex#1436
Open
Keksnet wants to merge 1 commit into
Open
Conversation
…yPattern annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this PR aims to fix #1435.
I removed the
^and$at the start and end of the regex respectively as they are already enforced by the usages of the regex itself. The regex is not used in a way that it could only match a part of the pattern.If I only remove those the regex would match
..again as valid to prevent that I added a non-capturing group inside the negative lookahead to make it compatible with a full key of the formnamespace:value.This non-capturing group does accept the end of the line or a colon as the end the namespace and therefore works either for matching the namespace or a full key.
All tests still pass and the warnings for
@KeyPatternalign with the expected test results as far as I can tell.Any feedback is welcome 🙂