Add back BuildableComponent#1432
Merged
Merged
Conversation
jpenilla
marked this pull request as ready for review
June 24, 2026 16:07
kennytv
approved these changes
Jun 26, 2026
kezz
approved these changes
Jun 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Jun 27, 2026
kezz
force-pushed
the
fix/expand-legacy-component-builder-abi-fix
branch
from
June 27, 2026 09:16
09f7add to
1cb2550
Compare
kezz
enabled auto-merge
June 27, 2026 09:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore binary compatibility for 4.x-compiled component builder calls that expect
build(): BuildableComponent.Adventure 5 changed
ComponentBuilder#build’s erased return type from the oldBuildableComponenthierarchy toComponent. Code compiled against Adventure 4.x can therefore fail at runtime on Adventure 5.x with:Fixes #1431.
Changes
BuildableComponentas a deprecated, for-removal compatibility type.BuildableComponentagain.in addition to the existing
build():Objectbridge.The public source API remains based on
ComponentBuilder<C extends Component, ...>, so normal newly compiled 5.x code continues to target the modern ABI:To emit bytecode referencing the restored legacy bridge, code must explicitly use the deprecated compatibility type, for example:
That usage produces deprecation/removal warnings and is not intended for new code.
Compatibility notes
This supports:
It does not make 5.x-compiled code run on Adventure 4.x, and it does not make
BuildableComponenta supported long-term API again. The restored type and bridge should be removed in 6.x.Verification
runs successfully against the rebuilt 5.x jar.
for
Component.text().build().BuildableComponentwhen source explicitly uses the deprecatedBuildableComponenttype.