pbook rewrite using Typer - #99
Open
fbarreir wants to merge 63 commits into
Open
Conversation
# Conflicts: # packages/light/pyproject.toml # pyproject.toml # setup.py
# Conflicts: # pyproject.toml
Contributor
There was a problem hiding this comment.
Pull request overview
This PR rewrites the pbook CLI entrypoint to use Typer (Click-based) to provide richer --help output and improved completion behavior, while keeping an interactive REPL mode and maintaining backward compatibility for legacy key=value batch arguments.
Changes:
- Replaced the legacy argparse-based
pandaclient/PBookScript.pyCLI implementation with a Typer app + interactive REPL integration (including legacykey=valuerewriting). - Added
typeras a dependency (both root andpackages/light). - Tweaked
PBookCore.reload_input()logging and return-code handling, and updated pre-commit hook versions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Adds typer dependency for the rewritten CLI. |
| packages/light/pyproject.toml | Adds typer dependency for the light package variant. |
| pandaclient/PBookScript.py | Major rewrite of pbook CLI using Typer; REPL/help/completion and legacy-arg compatibility logic added. |
| pandaclient/PBookCore.py | Adjusts reload_input() success/error condition and log message. |
| .pre-commit-config.yaml | Updates Black and isort hook revisions. |
Suppressed comments (1)
pandaclient/PBookScript.py:693
- Help text has a double period at the end ("task.."), which is likely an accidental typo.
typer.Option("--nGBPerJob", help="Maximum input size in GB to be processed by a single job in the task.."),
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better help documentation
Tab-completion