Give the Windows compat-smoke build a 30-minute timeout to absorb runner-setup variance#369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #360.
The python-compat-smoke-build job shared one 20-minute timeout across its OS matrix. On Windows, runner preparation (Free Disk Space) varies by several minutes and the pecos-rslib wheel compile alone takes 10-12, so a slow-setup run cancelled a healthy build with no compiler or test failure (PR #359 attempt 1; identical rerun passed in 15m58s).
Per the issue's proposed hardening, the timeout is now a per-matrix-entry value: Windows gets 30 minutes, Ubuntu and macOS keep 20. All build and compatibility coverage is unchanged; genuine failures still fail the job.
Testing