Use native otioz support - #165
Draft
darbyjohnston wants to merge 1 commit into
Draft
Conversation
Collaborator
|
@darbyjohnston do you mind making a separate PR for the CI fixes? I will land those right away then. Currently the ZLib issue is failing runs. |
Contributor
Author
Collaborator
|
Excellent! Thanks so much @darbyjohnston! |
darbyjohnston
force-pushed
the
otioz_cxx
branch
2 times, most recently
from
September 9, 2026 23:37
b32539e to
649990e
Compare
Read .otioz files with otio::bundle::read_otioz() instead of the hand-written minizip-ng reader. raven keeps its own minizip-ng and hands it to OTIO through OTIO_FIND_MINIZIP_NG, since OTIO's vendored minizip-ng pin does not build under Emscripten. Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
darbyjohnston
force-pushed
the
otioz_cxx
branch
from
September 9, 2026 23:43
649990e to
4b200cf
Compare
Contributor
Author
|
I updated the PR to work with the new CI fixes. |
Collaborator
|
@darbyjohnston I wonder if this is already worth landing. I guess there is an argument to keep referring to a released commit when it comes to OTIO, but Raven is still a WIP and pulls in OTIO only at build time? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for native C++ .otioz functionality.
The new .otioz functionality has not been released yet, so this is a draft to demonstrate the changes. Also it looks like the latest OTIO code has some API changes around marker colors which this does not address (I temporarily commented out the relevant code).
I also needed to update the macOS runner to
macos-14sincemacos-13has been retired.Example .otioz file:
Assisted-by: Claude:claude-opus-4-7 [code-review] [debugging]