feat: New version of OpenChannel - #85
Merged
Merged
Conversation
dietmarw
force-pushed
the
feat/openChannel
branch
2 times, most recently
from
March 19, 2026 07:37
06bc635 to
7f62d43
Compare
dietmarw-se
force-pushed
the
feat/openChannel
branch
from
March 26, 2026 13:31
7f62d43 to
f166982
Compare
dietmarw-se
force-pushed
the
feat/openChannel
branch
2 times, most recently
from
April 14, 2026 13:52
80cfbe3 to
26b2064
Compare
Collaborator
Author
|
I've worked through the suggested code and did adoptions to the rest of the library and think this is now good enough to be merged an in any case better than the existing broken implementation. |
dietmarw
marked this pull request as ready for review
April 17, 2026 10:23
dietmarw-se
force-pushed
the
feat/openChannel
branch
from
August 4, 2026 11:51
fd857a1 to
ca46b0c
Compare
…function to improve modularity. Introduces the option to specify the Manning friction coefficient 'n' or the Strickler coefficient 'M' (M = 1/n), providing more flexibility for model configuration. Simplifies the channel bed slope definition by replacing separate inlet and outlet bed elevations with a single total elevation difference 'H'.
…function to improve modularity. Introduces the option to specify the Manning friction coefficient 'n' or the Strickler coefficient 'M' (M = 1/n), providing more flexibility for model configuration. Simplifies the channel bed slope definition by replacing separate inlet and outlet bed elevations with a single total elevation difference 'H'.
dietmarw-se
force-pushed
the
feat/openChannel
branch
from
August 4, 2026 11:53
ca46b0c to
68c3dd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an experiment. The existing OpenChannel model was basically broken. So I used copilot to come up with an alternative. The result seems to work and is much simpler in its implementation then the old KP function based one (which was one of the instructions given).
Things that still need to be done is to investigate for unnecessary "slop" and how it can be integrated with the rest of the library better. For example should the embedded function be isolated. At the same time one should possibly make the configuration of the friction coefficients similar versatile like in the current pipe model (i.e., choice of n_manning, m_manning, p_eps)