tasks: add reusable rtpengine task#56
Open
NormB wants to merge 2 commits into
Open
Conversation
Add a first-class `rtpengine` task type so scenarios can run an rtpengine media proxy without an inline generic shell block. On a stock debian:trixie-slim base it apt-installs the Debian rtpengine-daemon package (sipwise upstream; userspace-only, no kernel dkms) and runs it in the foreground, and is healthy once the ng socket is bound so dependents gate on readiness rather than a fixed sleep. `ng_port` selects the ng control port; `ip`/`interface`/`table`/`options` and the install package list are configurable, and `install: false` skips the apt step for images that already ship rtpengine. Note `port`/`ports` are deliberately NOT aliased to the ng port: the base Task reserves them for container port publishing and a string value there would crash get_ports(). Includes unit tests for command assembly, the ng_port knob, the install/packages/options handling and adversarial (quoted) inputs, plus a regression test pinning that the opensips-mi task can run an arbitrary python script with forwarded args.
The `Run OpenSIPS Conformance Tests` workflow delegated to the tests repo's
reusable workflow, which checks out `${{ github.repository }}` as the tests
directory. Called from this framework repo that resolves to SIPssert itself,
so the matrix step ran `read_matrix.py tests/run.yml` against a repo with no
`run.yml` and exited 2 -- the job has been red on every push/PR since Feb 2026.
Run the suite inline instead: install the framework from THIS checkout (so a
PR's framework code is actually exercised) and pull the scenarios from
OpenSIPS/sipssert-opensips-tests explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a first-class
rtpenginetask type so scenarios can run an rtpengine media proxy without an inline generic shell block. On a stock debian:trixie-slim base it apt-installs the Debian rtpengine-daemon package (sipwise upstream; userspace-only, no kernel dkms) and runs it in the foreground, and is healthy once the ng socket is bound so dependents gate on readiness rather than a fixed sleep.ng_portselects the ng control port;ip/interface/table/optionsand the install package list are configurable, andinstall: falseskips the apt step for images that already ship rtpengine. Noteport/portsare deliberately NOT aliased to the ng port: the base Task reserves them for container port publishing and a string value there would crash get_ports().Includes unit tests for command assembly, the ng_port knob, the install/packages/options handling and adversarial (quoted) inputs, plus a regression test pinning that the opensips-mi task can run an arbitrary python script with forwarded args.