Skip to content

chore(deps): update dependency vite-plugin-dynamic-base to ^1.4.1 - #510

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/vite-plugin-dynamic-base-1.x
Open

chore(deps): update dependency vite-plugin-dynamic-base to ^1.4.1#510
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/vite-plugin-dynamic-base-1.x

Conversation

@renovate

@renovate renovate Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
vite-plugin-dynamic-base ^1.3.0^1.4.1 age confidence

Release Notes

chenxch/vite-plugin-dynamic-base (vite-plugin-dynamic-base)

v1.4.1

Compare Source

v1.4.0

Compare Source

2026-05-09

Fix
  • fix template literal asset path transformation for Vite 8 so asset URLs in template literals are correctly rewritten to use dynamic publicPath.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@xrgzs

xrgzs commented May 12, 2026

Copy link
Copy Markdown
Member

需要合并一下之前patch的修改,1.4.0可能并未完全修复问题

@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 6 times, most recently from 202583c to 24b8973 Compare May 18, 2026 17:45
@renovate renovate Bot changed the title chore(deps): update dependency vite-plugin-dynamic-base to ^1.4.0 chore(deps): update dependency vite-plugin-dynamic-base to ^1.4.1 May 18, 2026
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 4 times, most recently from 230d321 to eec7fe3 Compare May 29, 2026 07:09
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 2 times, most recently from 5a64810 to 277ce47 Compare June 3, 2026 00:38
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 3 times, most recently from 52f31cb to 9a4f662 Compare June 17, 2026 06:13
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 3 times, most recently from 4cc2849 to 45f758c Compare June 30, 2026 04:09
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 3 times, most recently from d85d9b1 to 19344ae Compare July 16, 2026 19:16
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch from 19344ae to 6c02dc7 Compare July 20, 2026 16:02
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 3 times, most recently from 5c19290 to 676e439 Compare July 30, 2026 15:12
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 2 times, most recently from beb9cb4 to 1aa290b Compare August 4, 2026 04:37
PIKACHUIM
PIKACHUIM previously approved these changes Aug 7, 2026
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 2 times, most recently from 152b894 to 15a1d3f Compare August 14, 2026 18:11
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch from 15a1d3f to b78c7ee Compare August 26, 2026 15:49
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch 2 times, most recently from 4ea5818 to 938ade5 Compare August 28, 2026 14:54

@pikachuren pikachuren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

结论:请求修改 — 本地 patch 无法应用到新版本

Build Check 失败原因很明确:

[ERR_PNPM_PATCH_FAILED] Could not apply patch
  patches/vite-plugin-dynamic-base.patch
  to node_modules/.pnpm/vite-plugin-dynamic-base@1.4.1_patch_hash=...

仓库在 pnpm-workspace.yaml 里对这个依赖挂了本地补丁:

patchedDependencies:
  # if https://github.com/chenxch/vite-plugin-dynamic-base/pull/36 is merged,
  # this patch can be removed
  vite-plugin-dynamic-base: patches/vite-plugin-dynamic-base.patch

补丁改的是 dist/core/utils.js 里的 replaceInStringLiteralreplaceInTemplateElement,1.4.1 的这两个函数实现发生了变化,上下文对不上导致 patch 应用失败,安装阶段直接中断。

这里有个前置判断需要先做:补丁注释指向上游 PR chenxch/vite-plugin-dynamic-base#36,如果 1.4.1 已经合入了等价修复,那么正确做法不是重做补丁,而是连同补丁一起删除——保留一个功能重复的补丁反而可能把已修好的行为改坏。所以建议按顺序确认:

  1. 先核对 1.4.1 的 dist/core/utils.js,看这两处修改(用 literal.raw 而非 literal.value 以保留转义、以及模板字面量替换去掉多余的前导 /)是否已包含在上游;
  2. 若已包含,从 pnpm-workspace.yaml 移除 patchedDependencies 条目并删掉 patches/vite-plugin-dynamic-base.patch
  3. 若未包含,用 pnpm patch vite-plugin-dynamic-base@1.4.1 基于新版本重新生成补丁。

无论走哪条路,合并前都需要验证子路径部署(非根 base)下资源路径重写仍然正确,这正是该补丁要解决的问题,回归了不容易被常规构建发现。当前状态不能合并。

@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch from 938ade5 to 3d0e953 Compare September 2, 2026 16:54
@renovate
renovate Bot force-pushed the renovate/vite-plugin-dynamic-base-1.x branch from 3d0e953 to f814269 Compare September 7, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants