Skip to content

fix(acp): add claude-fable-5 to Claude Code model picker options (#16440) - #4437

Open
KHARSHAVARDHAN-eng wants to merge 1 commit into
OpenHands:mainfrom
KHARSHAVARDHAN-eng:fix/acp-claude-fable-5-model-picker-16440
Open

fix(acp): add claude-fable-5 to Claude Code model picker options (#16440)#4437
KHARSHAVARDHAN-eng wants to merge 1 commit into
OpenHands:mainfrom
KHARSHAVARDHAN-eng:fix/acp-claude-fable-5-model-picker-16440

Conversation

@KHARSHAVARDHAN-eng

@KHARSHAVARDHAN-eng KHARSHAVARDHAN-eng commented Aug 9, 2026

Copy link
Copy Markdown

HUMAN:

  • A human has tested these changes.

AGENT:


Why

Fixes OpenHands/OpenHands#16440 where claude-fable-5 was missing from the available model suggestions for ACP Claude Code sessions.

Summary

  • Added ACPModelOption(id="claude-fable-5", label="Claude Fable 5") to _CLAUDE_MODELS in acp_providers.py.
  • Updated unit test assertions in test_acp_providers.py.

Issue Number

Fixes OpenHands/OpenHands#16440

How to Test

Run unit tests:

uv run pytest tests/sdk/settings/test_acp_providers.py

@VascoSch92 VascoSch92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you link an issue for these changes? Thanks

@KHARSHAVARDHAN-eng
KHARSHAVARDHAN-eng force-pushed the fix/acp-claude-fable-5-model-picker-16440 branch from 866885a to e1639fe Compare August 10, 2026 08:41
@KHARSHAVARDHAN-eng

Copy link
Copy Markdown
Author

I have updated the PR description to link cross-repository issue OpenHands/OpenHands#16440 and rebased the branch down to a single clean commit. Thanks!

@KHARSHAVARDHAN-eng

Copy link
Copy Markdown
Author

I have updated the PR description to link cross-repository issue OpenHands/OpenHands#16440 and rebased the branch down to a single clean commit.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACP Claude Code: model picker should list all models available to the account (incl. claude-fable-5), not only the SDK alias menu

2 participants