fix(sdk): disable switch_llm by default (#16442) - #4436
Open
KHARSHAVARDHAN-eng wants to merge 1 commit into
Open
fix(sdk): disable switch_llm by default (#16442)#4436KHARSHAVARDHAN-eng wants to merge 1 commit into
KHARSHAVARDHAN-eng wants to merge 1 commit into
Conversation
enyst
requested changes
Aug 9, 2026
| GitCommandError: If the git command fails | ||
| """ | ||
| if args and args[0] == "git" and not any("core.quotePath" in a for a in args): | ||
| args = ["git", "-c", "core.quotePath=false", *args[1:]] |
Member
There was a problem hiding this comment.
All the git changes don't seem related to the PR, was this unintentional?
Member
|
Hey, thank you for the proposal! I'm not sure that this is the root cause, or the right fix. Could you show logs where the agent switches LLM and that caused a problem? |
This was referenced Aug 9, 2026
KHARSHAVARDHAN-eng
force-pushed
the
fix/disable-switch-llm-tool-default-16442
branch
from
August 10, 2026 02:47
da7e079 to
b90cd5e
Compare
Author
|
Hi @enyst, thank you for the review! Here is a summary of the updates made to address your feedback:
All 207 unit tests ( Let me know if any other required changes has to be made!! Thanks!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
Why
Fixes #16442 by disabling
switch_llmby default in the SDK agent settings and profiles, and annotatingSwitchLLMToolwithdestructiveHint=Trueto require user confirmation when enabled.Summary
enable_switch_llm_tooldefault value fromTruetoFalseinOpenHandsAgentSettingsandAgentProfile.SwitchLLMToolwithdestructiveHint=Trueso model switching operations trigger confirmation flows under policies requiring user approval.test_switch_llm.py,test_settings.py,test_resolver.py, andtest_agent_profile.py.Issue Number
Fixes #16442
How to Test
Run SDK unit tests: