feat(skills): add server-side-conversion-tracking skill - #459
Open
autonnel wants to merge 2 commits into
Open
Conversation
Contributor
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Conversions get under-reported when browser pixels are blocked or truncated, and the usual symptom is that platform-reported purchases stop matching the order table, which then degrades ad optimization. There is no skill in
skills/covering the server-side reporting chain that fixes this.Summary
skills/server-side-conversion-tracking/SKILL.md(categoryintegrations): click id capture and passthrough, server-side session, order write, queued delivery to Facebook Conversions API / TikTok Events API / Google Ads and Bing, deduplication against the browser pixel, reconciliation against real orders, plus a verification checklist and an explicit "what this does not fix" section.marketplaces/openhands-extensions.json, regeneratesskills/index.jsand the README catalog section.EXPECTED_CATEGORY_COUNTS["integrations"]6 to 7 intests/test_skills_catalog.py, which is required for any newintegrationsentry.Issue Number
N/A
How to Test
What I ran locally before opening this, and the result:
npm run build:skills- catalog regenerated, the new entry appears withcategory: "integrations".python scripts/sync_extensions.py- README catalog section updated. The only coverage warning it prints (plugins/issue-duplicate-checkernot in any marketplace) pre-exists onmainand is untouched here.pytest tests/test_skills_catalog.py tests/test_catalogs.py- 48 passed. Without theEXPECTED_CATEGORY_COUNTSbump,test_category_distribution_is_balancedfails with{'integrations': 7} != {'integrations': 6}.openhandsSDK. I did not install it locally, so that coverage is left to CI.The skill's own content is documentation of platform HTTP endpoints; it ships no scripts or executables, so there is nothing else to execute here.
Video/Screenshots
Not applicable - this PR adds a Markdown skill and catalog metadata, no UI surface.
Notes
Disclosure: the "Implementing it" section points at Autonnel (Apache-2.0, self-hosted) as a reference implementation of the full chain, and I maintain that project. The rest of the skill is stack-independent and the reference carries no setup instructions. Happy to drop that paragraph if you would rather the skill carry no product reference.