Skip to content

Add --param flag to bss boot image set to set the name of the kernel parameter the image is passed with #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wafffle77 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

Add --param flag to bss boot image set to set the name of the kernel parameter the image is passed with #103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda3539
Add bss boot image set --param flag for setting the image parameter n…
Wafffle77 Jun 19, 2026
856d07b
fix(bss): make boot image set --param usage more readable
Wafffle77 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cmd/bss/boot/image/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,11 +158,18 @@ See ochami-bss(1) for more details.`,
}
}

image_param_name, err := cmd.Flags().GetString("param")
if err != nil {
log.Logger.Error().Err(err).Msg("unable to get image param name")
cli.LogHelpError(cmd)
os.Exit(1)
}

errorsOccurred := false
for bpIdx, bp := range bps {
// Edit parameters for nodes
k := kargs.NewKargs([]byte(bp.Params))
k.SetKarg("root", args[0])
k.SetKarg(image_param_name, args[0])
bps[bpIdx].Params = k.String()

// Send modified params back to BSS
Expand All @@ -187,6 +194,7 @@ See ochami-bss(1) for more details.`,
// Create flags
bootImageSetCmd.Flags().StringSliceP("xname", "x", []string{}, "one or more xnames whose boot parameters to set")
bootImageSetCmd.Flags().StringSliceP("mac", "m", []string{}, "one or more MAC addresses whose boot parameters to set")
bootImageSetCmd.Flags().StringP("param", "p", "root", "set the kernel parameter name that the image is passed with")
bootImageSetCmd.Flags().Int32SliceP("nid", "n", []int32{}, "one or more node IDs whose boot parameters to set")

bootImageSetCmd.MarkFlagsOneRequired("xname", "mac", "nid")
Expand Down
Loading