This repository was archived by the owner on Oct 1, 2026. It is now read-only.
Repository navigation
Custom agent features and user feedback docs - #153
Merged
Merged
Conversation
piiq
reviewed
Apr 19, 2026
| # Text/select features — parse "key=value" entries | ||
| def get_option_value(key: str, default: str = "") -> str: | ||
| for opt in workspace_options: | ||
| if opt.startswith(f"{key}="): |
Contributor
There was a problem hiding this comment.
Only when I read the docs I realize this is how it's implemented. Any reason string based implementation was chosen?
Is it to avoid changing the QueryRequest schema?
Contributor
Author
There was a problem hiding this comment.
I believe it was yes. But now that you point it out I do think we can do better.
What do you think? @piiq
piiq
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add custom agent features (str and dropdown) and also how to get user feedback