Skip to content

Final Merge#791

Merged
prathieshna merged 18 commits into
nextfrom
temp/next-prod-release-8th-june-2026
Jul 13, 2026
Merged

Final Merge#791
prathieshna merged 18 commits into
nextfrom
temp/next-prod-release-8th-june-2026

Update `IaConduit` to treat `meta.json` upload failure as a fatal error.

e668c0f
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / detekt succeeded Jul 12, 2026 in 7s

284 new alerts

New alerts in code changed by this pull request

  • 284 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 8 in app/src/foss/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Function parameter is unused and should be removed. Warning

Function parameter context is unused.

Check warning on line 8 in app/src/foss/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Function parameter is unused and should be removed. Warning

Function parameter mediaHash is unused.

Check warning on line 8 in app/src/foss/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Function parameter is unused and should be removed. Warning

Function parameter outFile is unused.

Check warning on line 3 in app/src/gms/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Detects imports in non default order Warning

Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

Check warning on line 19 in app/src/gms/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Argument should be on a separate line (unless all arguments can fit a single line)

Check warning on line 19 in app/src/gms/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Reports missing newlines (e.g. between parentheses of a multi-line function call Warning

Missing newline after "("

Check warning on line 20 in app/src/gms/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Reports missing newlines (e.g. between parentheses of a multi-line function call Warning

Missing newline before ")"

Check warning on line 20 in app/src/gms/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

Reports incorrect argument list wrapping Warning

Missing newline before ")"

Check warning on line 26 in app/src/gms/java/net/opendasharchive/openarchive/util/SafetyNetHelper.kt

See this annotation in the file changed.

Code scanning / detekt

The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled. Warning

The caught exception is too generic. Prefer catching specific exceptions to the case that is currently handled.

Check warning on line 294 in app/src/main/java/net/opendasharchive/openarchive/features/media/camera/CameraViewModel.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 232 in app/src/main/java/net/opendasharchive/openarchive/util/MetadataCollector.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 233 in app/src/main/java/net/opendasharchive/openarchive/util/MetadataCollector.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 233 in app/src/main/java/net/opendasharchive/openarchive/util/MetadataCollector.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 3 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Detects imports in non default order Warning

Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

Check warning on line 46 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Too many functions inside a/an file/class/object/interface always indicate a violation of the single responsibility principle. Maybe the file/class/object/interface wants to manage too many things at once. Extract functionality which clearly belongs together. Warning

Object 'ProofCompanionGenerator' with '24' functions detected. Defined threshold inside objects is set to '11'

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.

Check warning on line 60 in app/src/main/java/net/opendasharchive/openarchive/util/ProofCompanionGenerator.kt

See this annotation in the file changed.

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers. Warning

This expression contains a magic number. Consider defining it to a well named constant.