[php-nextgen] Fix undefined variable $queryParams#24136
Open
wuchen90 wants to merge 1 commit into
Open
Conversation
Author
|
@jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon |
Member
|
thanks for the PR cc @coffeemakr @JulianVennen as well. |
a3ed98d to
f1811a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$queryParamsis used in the generated code below so this variable must exist in order to avoid undefined variable error.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Always initialize
$queryParamsinphp-nextgengenerated API methods to eliminate “undefined variable $queryParams” when endpoints have no query params. The template now sets it by default and samples are regenerated to match.{{#hasQueryParams}}guard and unconditionally set$queryParams = [];inphp-nextgen/api.mustache.php-nextgenandphp-nextgen-streaming(echo_api) and petstorephp-nextgenso all endpoints include the$queryParamsinitialization.Written for commit f1811a3. Summary will update on new commits.