Repository navigation
ci(wheels): assert every shipped module imports from the installed wheel - #8
Merged
Merged
Conversation
The wheel test command imported vdsim and built Sim twice; it never touched vdsim_render, so a wheel that shipped vdsim_render.py without the vdsim_preset.py it imports passed the whole 6-wheel matrix plus the verify job (measured 2026-09-18, pre-flight C-2). tools/wheel_import_smoke.py reads the install list out of python/CMakeLists.txt - the file that decides what ships - and imports every listed module, asserting each resolves to the installed distribution rather than to the checkout. Names are never restated in the workflow, so the check follows the list when it changes. matplotlib/pillow join CIBW_TEST_REQUIRES because vdsim_render imports them at module scope; they are the declared [plot] extra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes the wheel import-closure hole that let
vdsim_preset.pyship missing (fixed in #7) pass every gate we had.Two files, no core changes:
tools/wheel_import_smoke.pypython/CMakeLists.txt(single source — the module names are not re-typed in the workflow), imports every shipped module, and asserts each resolves under the installed wheel rather than the checkout..github/workflows/wheels.ymlCIBW_TEST_COMMANDruns the smoke script;CIBW_TEST_REQUIRESgainsmatplotlib pillow.CIBW_TEST_REQUIRES'smatplotlib/pilloware the already-declared[plot]extra —vdsim_renderimports them at module scope, so the closure check needs them in the test env.install_requiresis unchanged; this is not a runtime dependency increase.Why this is not a 3x-consecutive-count PR
Changed surface is
.github/workflows/wheels.yml+tools/**only.CMakePresets.json, everyCMakeLists.txt,cmake/**) diff vsmain: 0 filesdocs/VALIDATION.mdcurrency stays canonical (no PENDING transition)build.ymlrunDetection evidence
Dry-run against a deliberately stale site-packages resolves 13 modules and flags exactly the shipping gaps:
That is the #7 defect class reproduced by the check that would have caught it.
What it does not cover
Import-time only. A module that imports cleanly but needs a data file absent from the wheel still passes here — that is what pre-flight C-2 (clean venv, no source tree, quickstart + demo) is for.