Repository navigation
Conversation
…ation Gate code for work order 48c, committed ahead of the implementation: camber/toe output equal to the free functions every tick, product-toe sign, static coordinates against the part YAML plus the per-axle x offset at attach and after reset, rigid link lengths over a bump x rack sweep, left/right mirror, rack_per_rad default/half/round trip, L4 and non-hardpoint paths exporting nothing, and the Python attach, bit-equality and trace checks. This commit does not build on its own; the next commits add the API it uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SimOutput carries per-wheel camber, toe, validity and hardpoint coordinates in the vehicle design frame on the L5 strut path; the two rack-per-radian constants become VehicleParams.rack_per_rad; Python reads the new fields and attaches L5 hardpoints through vdsim.attach_l5_hardpoints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The five-link driven pose is a least-squares fit, so its link lengths are not held exactly. The corner model reports an exclusion reason; the L5 session then exports no points for that axle and the layout and trace manifest record why. Camber and toe are still reported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Changed after measurement on the PO verdict for the 48c K4 halt (option 1): thresholds unchanged, five-link exclusion asserted in C++ and Python, the five-link link-length sweep kept runnable under the known_failure label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
L5 per-wheel camber, toe and hardpoint-coordinate output on the strut path with a corner model, and one
VehicleParams.rack_per_radkey in place of the two rack-per-radian constants (work order 48c, 0.8.2). Dynamics unchanged: without the new key and without reading the new outputs every level is bit-identical to 645780c.What changes
SimOutput:wheel_camber,wheel_toe[rad] (equal tofree_3d_wheel_camber/toe, product toe of theory 14 §14.16),wheel_kin_valid,hardpoints(per wheel,countpoints [m]). L1-L4 and wheels without a corner model: 0, valid false, no points.axle_offset_x = -wheelbase - w_rear.x; right wheels are the left part mirrored in y.wheel_center_dy = w.y - track/2is recorded, coordinates are not moved in y.free_3d_hardpoint_layout()(names,axle_offset_x,wheel_center_dy,excluded),free_3d_wheel_kin_valid(),free_3d_wheel_hardpoints(),free_3d_rack_dy(); all exposed to Python.VehicleParams.rack_per_rad(default 0.08 m/rad), used by L4 and L5roadwheelmode; YAML / Python /to_yamlround trip, invalid values raise.vdsim.attach_l5_hardpoints(...);vdsim_lab.attach_kinematicsdelegates to it on L5. The L3/L4 attach keeps returning False on L5..vdtraceschema stays 0.5: opt-inwheel_camber,wheel_toe(4,) andhp_<wheel>_<key>(3,) channels (regex^hp_(fl|fr|rl|rr)_[a-z0-9_]+$), manifesthardpointsblock; an invalid wheel is NaN.excludedreason; manifestpoints: {}+excluded). Camber and toe are still reported (they are the values the tyre uses).Gates (48c sec. 4, fixed in 5ec3702 before the implementation)
t_compute_s/compute_*differ)reset()rack_per_radl5_hardpointsctest passesC++ and Python counted separately: C++ 16 new tests (unit 4, integration 12), Python 1 new ctest.
Changed after measurement
FiveLinkCornerExportsNoPoints, Python manifest check) and keeps the five-link sweep runnable asL5HardpointKnownFailure.K4FiveLinkPrescribedSweep(labelknown_failure, excluded from the validation preset). 5ec3702 is untouched.Documentation impact (W1)
CHANGELOG
[0.8.2](Added, Known limitations: L4 no output, five-link exclusion,wheel_center_dy),docs/theory/14_hardpoint_kinematics.md§14.17 (frame, point lists,rack_per_rad, trace channels and manifest),docs/EXPERIMENT_API.mdtrace channel note,docs/VALIDATION.mdcurrency PENDING. Doc audit: FAIL set on HEAD equals 645780c (pre-existing A1 only).Shared files with work order 47
free_3d_dynamics.cpp,params.*,bindings.cpp: whichever lands second merges main (no rebase).Local verification
ctest --preset validation --parallel 4: all passed (main 595 + 17 new).ctest -L known_failure: the two R2 items and the five-link K4 item, as labelled.CI measurement
PENDING: same-head complete successes x3, currency confirmation, final run and wheels. No merge, tag or publication performed.
🤖 Generated with Claude Code