Repository navigation
Actuator library: runtime swap, direct-control session, actuator option on VDSimPlant - #23
Merged
Merged
Conversation
…sh and user-defined stage Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dings, generic presets Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l options, closed-loop touch point Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…brary tree Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Docs-only: fills the VALIDATION currency block measured on the previous head of this branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Actuator library (work order 32): runtime actuator swap, direct-control session, backlash and user-defined stage, cascade gains and sensor lag, the
actuator=option onVDSimPlant, generic actuator presets, and the actuator guide in the docs navigation.The retired direct-control-level branch is not merged. Its two options are pinned by equivalence tests in this PR instead:
actuator={"steer":{"dead_time_s":...}}delays the command by the exact number of substeps.levelargument.ClosedLoopEvalmode A vs B with zero latency is bit-identical whenVDSimPlantcarriesactuator=.How this branch was built
This branch starts from
origin/mainb820364 and carries the final tree of the local working branch as six logical commits.7e538ed(local branch, never pushed).git diff 7e538ed HEADis empty, so the local results below were measured on the same tree.History checks on the new head:
git diff --check origin/main HEADflags trailing whitespace only incore/include/vdsim/vec_session.hppandcore/src/vec_session.cpp. Both files are CRLF on main already (every line), and the added lines keep the file's CRLF ending, so this is not a line-ending rewrite.Local verification (tree 7e538ed = this head)
Host ailab-12, cores 0-9,12-23, cmake/ctest 3.31.10.
ctest --preset validation -j1ctest -L timingoncetests/rlby hand: test_rl_env, test_rl_randomization_seed, test_rl_settle_snapshotFresh build of this branch's worktree (head a2358a8):
ctest --preset validationrc 0, 532 / 532 passed.Validation currency
The registered surface changed (new script tests in
cosim/CMakeLists.txt), so the count was fixed by three CI attempts on one head.closedloop_wallclock_timingappears 0 times in the CI logs (timing label excluded by the validation preset).Windows wheel (manual
wheels.ymldispatch, run 38349552030 on 8f5a8dd): sdist, wheels windows-latest, wheels ubuntu-latest, verify all success; publish skipped.Known issues
levelstring to L2 without an error. Not changed in this PR; tracked as a follow-up.B3 (information)
On main, L3 vs L4 direct-control state difference for the same scenario is zero. A first non-zero reading came from the probe script building the two sessions differently, not from the code.
🤖 Generated with Claude Code